New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GL_ARB_compatibility not being detected #859

Merged
merged 1 commit into from Apr 8, 2015

Conversation

Projects
None yet
3 participants
@binary1248
Member

binary1248 commented Apr 4, 2015

When a 3.1 context is created on systems that support only up to 3.1, warnings were printed about incompatibilities even when GL_ARB_compatibility is present. This patch fixes that by checking for GL_ARB_compatibility when updating the context settings after creation.

See here.

@binary1248 binary1248 self-assigned this Apr 4, 2015

@binary1248 binary1248 added this to the 2.3 milestone Apr 4, 2015

binary1248 referenced this pull request Apr 4, 2015

Added check to context creation to warn the user of an incompatible m…
…ismatch between the context they requested and the context that was created.
@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Apr 4, 2015

Member

Nice, the error message has disappeared 👍

Member

Bromeon commented Apr 4, 2015

Nice, the error message has disappeared 👍

@eXpl0it3r eXpl0it3r added the s:accepted label Apr 5, 2015

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 5, 2015

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Apr 5, 2015

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Fixed GL_ARB_compatibility not being detected causing false compatibi…
…lity warnings to be emitted when a 3.1 context is created.

@eXpl0it3r eXpl0it3r merged commit 01f46ce into master Apr 8, 2015

@eXpl0it3r eXpl0it3r deleted the bugfix/gl_arb_compatibility branch Apr 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment