New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pixel format selection #862

Closed
wants to merge 0 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@binary1248
Member

binary1248 commented Apr 8, 2015

Fixes this.

Currently, the format scoring is kind of.... broken. In certain configurations such as this one, where 8x MSAA is always coupled with a 24-bit depth buffer, the configuration would always get scored worse than 0x AA and 0-bit depth leading to AA being disabled unless depth is explicitly set to 24-bit as well.

This patch fixes the issue by giving more allowance to better configurations so that even though they don't match the requested settings exactly, a configuration that is "too good" can't get overshadowed by a configuration that simply matches the most fields.

@konstin Can you give this a test?

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 13, 2015

Member

@konstin could you give this another try?

Member

eXpl0it3r commented Apr 13, 2015

@konstin could you give this another try?

@konstin

This comment has been minimized.

Show comment
Hide comment
@konstin

konstin Apr 13, 2015

It works perfectly!

I was pretty sure though that I already commented at #35 but it actually seems that I didn't...

konstin commented Apr 13, 2015

It works perfectly!

I was pretty sure though that I already commented at #35 but it actually seems that I didn't...

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 13, 2015

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Apr 13, 2015

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 14, 2015

Member

Merged in ac3a539

Member

eXpl0it3r commented Apr 14, 2015

Merged in ac3a539

@eXpl0it3r eXpl0it3r closed this Apr 14, 2015

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 14, 2015

Member

Merged an outdated version of this branch...

@binary1248 Could you rebase this branch, so I could apply the missing changes?

Member

eXpl0it3r commented Apr 14, 2015

Merged an outdated version of this branch...

@binary1248 Could you rebase this branch, so I could apply the missing changes?

@eXpl0it3r eXpl0it3r reopened this Apr 14, 2015

@eXpl0it3r eXpl0it3r closed this Apr 14, 2015

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 14, 2015

Member

Fully merged in 53f61e9

Also we broke GitHub 🙀

Member

eXpl0it3r commented Apr 14, 2015

Fully merged in 53f61e9

Also we broke GitHub 🙀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment