New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warning about switches #863

Merged
merged 1 commit into from Apr 14, 2015

Conversation

Projects
None yet
4 participants
@mantognini
Member

mantognini commented Apr 12, 2015

This patch silences warnings such as:

warning: default label in switch which covers all enumeration values [-Wcovered-switch-default]

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Apr 12, 2015

Member

Good one 👍

It's important to not have a default label in switches that are supposed to handle all the possible enumeration values, so that the compiler can warn you if you forget one.

Member

LaurentGomila commented Apr 12, 2015

Good one 👍

It's important to not have a default label in switches that are supposed to handle all the possible enumeration values, so that the compiler can warn you if you forget one.

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Apr 13, 2015

Member

👍

Member

binary1248 commented Apr 13, 2015

👍

@mantognini mantognini self-assigned this Apr 13, 2015

@mantognini mantognini added this to the 2.3 milestone Apr 13, 2015

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 13, 2015

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Apr 13, 2015

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r merged commit 4992243 into master Apr 14, 2015

14 checks passed

sfml-debian-64-gcc Build #112 succeeded in 1 min 28 sec
Details
sfml-freebsd Build #668 succeeded in 4 min 4 sec
Details
sfml-windows7-32-mingw492 Build #79 succeeded in 1 min 10 sec
Details
sfml-windows7-32-msvc10 Build #55 succeeded in 3 min 30 sec
Details
sfml-windows7-32-msvc11 Build #55 succeeded in 4 min 11 sec
Details
sfml-windows7-32-msvc12 Build #53 succeeded in 1 min 33 sec
Details
sfml-windows7-32-tdm471 Build #52 succeeded in 4 min 55 sec
Details
sfml-windows7-32-tdm481 Build #54 succeeded in 1 min 2 sec
Details
sfml-windows7-64-mingw492 Build #63 succeeded in 3 min 30 sec
Details
sfml-windows7-64-msvc10 Build #56 succeeded in 1 min 23 sec
Details
sfml-windows7-64-msvc11 Build #52 succeeded in 1 min 40 sec
Details
sfml-windows7-64-msvc12 Build #69 succeeded in 1 min 33 sec
Details
sfml-windows7-64-tdm471 Build #54 succeeded in 4 min 0 sec
Details
sfml-windows7-64-tdm481 Build #72 succeeded in 1 min 21 sec
Details

@eXpl0it3r eXpl0it3r deleted the bugfix/warnings branch Apr 14, 2015

@mantognini mantognini removed their assignment Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment