New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for software OpenGL #870

Merged
merged 1 commit into from Apr 21, 2015

Conversation

Projects
None yet
6 participants
@binary1248
Member

binary1248 commented Apr 18, 2015

After an OpenGL context is created, the vendor and renderer strings are checked against a blacklist (currently containing only 1 item 馃槢) of known software implementations and a warning is issued if that the context is indeed not hardware-accelerated.

Supersedes #867.

Show outdated Hide outdated src/SFML/Window/GlContext.cpp Outdated
@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Apr 19, 2015

Member

@LaurentGomila, @mantognini, @eXpl0it3r, @TankOs, @Bromeon, @MarioLiebisch, @Sonkun
2.3 or 2.4? This is kind of a trivial check, so nothing speaks against including it along with the other checks as part of the 2.3 release.

Member

binary1248 commented Apr 19, 2015

@LaurentGomila, @mantognini, @eXpl0it3r, @TankOs, @Bromeon, @MarioLiebisch, @Sonkun
2.3 or 2.4? This is kind of a trivial check, so nothing speaks against including it along with the other checks as part of the 2.3 release.

@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Apr 19, 2015

Member

Looks good to me. Does anybody happen to have a configuration with generic drivers, to test if they get the warning?

Member

Bromeon commented Apr 19, 2015

Looks good to me. Does anybody happen to have a configuration with generic drivers, to test if they get the warning?

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Apr 19, 2015

Member

@eXpl0it3r managed to test #858 with a disabled driver, forcing the software OpenGL implementation on Windows, maybe he can do it again? 馃槢

Member

binary1248 commented Apr 19, 2015

@eXpl0it3r managed to test #858 with a disabled driver, forcing the software OpenGL implementation on Windows, maybe he can do it again? 馃槢

@mantognini mantognini added this to the 2.3 milestone Apr 19, 2015

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Apr 19, 2015

Member

馃憤

Member

mantognini commented Apr 19, 2015

馃憤

@LaurentGomila

This comment has been minimized.

Show comment
Hide comment
@LaurentGomila

LaurentGomila Apr 19, 2015

Member

Maybe it's just me, but the warning Detected "Microsoft Corporation" "GDI Generic" looks strange (we have detected the Microsoft Corporation? 馃槢). Maybe appending "OpenGL implementation" or "OpenGL driver" to it would be clearer.

Member

LaurentGomila commented Apr 19, 2015

Maybe it's just me, but the warning Detected "Microsoft Corporation" "GDI Generic" looks strange (we have detected the Microsoft Corporation? 馃槢). Maybe appending "OpenGL implementation" or "OpenGL driver" to it would be clearer.

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Apr 19, 2015

Member

Maybe appending "OpenGL implementation" or "OpenGL driver" to it would be clearer.

Fixed.

Member

binary1248 commented Apr 19, 2015

Maybe appending "OpenGL implementation" or "OpenGL driver" to it would be clearer.

Fixed.

@TankOs

This comment has been minimized.

Show comment
Hide comment
@TankOs

TankOs Apr 19, 2015

Member

馃憤 馃悎 for 2.3

Member

TankOs commented Apr 19, 2015

馃憤 馃悎 for 2.3

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Apr 20, 2015

Member

shader / opengl

Warning: Detected "Microsoft Corporation GDI Generic" OpenGL implementation
The current OpenGL implementation is not hardware-accelerated
Setting vertical sync not supported
OpenGL extension SGIS_texture_edge_clamp unavailable
Artifacts may occur along texture edges
Ensure that hardware acceleration is enabled if available

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Apr 20, 2015

shader / opengl

Warning: Detected "Microsoft Corporation GDI Generic" OpenGL implementation
The current OpenGL implementation is not hardware-accelerated
Setting vertical sync not supported
OpenGL extension SGIS_texture_edge_clamp unavailable
Artifacts may occur along texture edges
Ensure that hardware acceleration is enabled if available

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Apr 20, 2015

Member

馃憤

Member

binary1248 commented Apr 20, 2015

馃憤

Added OpenGL vendor and renderer string checks to warn if the applica鈥
鈥ion is being run using a non-accelerated OpenGL context.

@eXpl0it3r eXpl0it3r merged commit e0d2735 into master Apr 21, 2015

13 checks passed

sfml-debian-64-gcc Build #128 succeeded in 1 min 26 sec
Details
sfml-windows7-32-mingw492 Build #94 succeeded in 1 min 14 sec
Details
sfml-windows7-32-msvc10 Build #70 succeeded in 3 min 35 sec
Details
sfml-windows7-32-msvc11 Build #70 succeeded in 1 min 46 sec
Details
sfml-windows7-32-msvc12 Build #68 succeeded in 1 min 49 sec
Details
sfml-windows7-32-tdm471 Build #67 succeeded in 4 min 22 sec
Details
sfml-windows7-32-tdm481 Build #69 succeeded in 1 min 9 sec
Details
sfml-windows7-64-mingw492 Build #78 succeeded in 4 min 18 sec
Details
sfml-windows7-64-msvc10 Build #71 succeeded in 1 min 18 sec
Details
sfml-windows7-64-msvc11 Build #67 succeeded in 1 min 40 sec
Details
sfml-windows7-64-msvc12 Build #84 succeeded in 4 min 8 sec
Details
sfml-windows7-64-tdm471 Build #69 succeeded in 4 min 53 sec
Details
sfml-windows7-64-tdm481 Build #87 succeeded in 1 min 15 sec
Details

@eXpl0it3r eXpl0it3r deleted the feature/software_gl_warn branch Apr 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment