New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Fixed audio files not loading (and possibly crashing) #887

Closed
wants to merge 1 commit into
base: 2.3.x
from

Conversation

4 participants
@MarioLiebisch
Member

MarioLiebisch commented May 12, 2015

  • Added a missing return value for Android's sf::FileInputStream::open().
  • Added a missing return value for Android's sf::priv::ResourceStream::seek().
  • Moved error logging for sf::InputSoundFile and sf::OutputSoundFile to sf::SoundFileFactory, since this allows more details on why reading/writing failed. Before missing files would return "format not supported".
Android: Fixed audio files not loading (and possibly crashing)
* Added a missing return value for Android's `sf::FileInputStream::open()`.
* Added a missing return value for Android's `sf::priv::ResourceStream::seek()`.
* Moved error logging for `sf::InputSoundFile` and `sf::OutputSoundFile` to `sf::SoundFileFactory`, since this allows more details on *why* reading/writing failed. Before missing files would return "format not supported".
@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 12, 2015

Member

Looks fine to me.

Member

eXpl0it3r commented May 12, 2015

Looks fine to me.

@Aykelith

This comment has been minimized.

Show comment
Hide comment
@Aykelith

Aykelith May 12, 2015

Tested on x86 - API22 - emulator: everything works fine but also got this in the log:

eglCodecCommon﹕ glUtilsParamSize: unknow param 0x0000821b
eglCodecCommon﹕ glUtilsParamSize: unknow param 0x0000821c
eglCodecCommon﹕ glUtilsParamSize: unknow param 0x0000821e
Failed to activate the window's context

But on armeabi-v7a - API15 - emulator still got sigsev( and the errors above):

Fatal signal 11 (SIGSEGV) at 0xdeadd00d (code=1)

And on my phone( API15) I got:

Caused by: java.lang.IllegalArgumentException: Unable to find native library: sfml-activity

Aykelith commented May 12, 2015

Tested on x86 - API22 - emulator: everything works fine but also got this in the log:

eglCodecCommon﹕ glUtilsParamSize: unknow param 0x0000821b
eglCodecCommon﹕ glUtilsParamSize: unknow param 0x0000821c
eglCodecCommon﹕ glUtilsParamSize: unknow param 0x0000821e
Failed to activate the window's context

But on armeabi-v7a - API15 - emulator still got sigsev( and the errors above):

Fatal signal 11 (SIGSEGV) at 0xdeadd00d (code=1)

And on my phone( API15) I got:

Caused by: java.lang.IllegalArgumentException: Unable to find native library: sfml-activity

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch May 12, 2015

Member

@Aykelith That's a different issue, something about OpenGL ES, the sigsegv most likely as well (both might actually be the same thing).

Member

MarioLiebisch commented May 12, 2015

@Aykelith That's a different issue, something about OpenGL ES, the sigsegv most likely as well (both might actually be the same thing).

@DontWorry33

This comment has been minimized.

Show comment
Hide comment
@DontWorry33

DontWorry33 May 12, 2015

Tested this on API19 emulator, the canary.wav now works and doesn't generate an error anymore. I still am getting called unimplemented OpenGL ES API (as you stated above, it is a different issue).

DontWorry33 commented May 12, 2015

Tested this on API19 emulator, the canary.wav now works and doesn't generate an error anymore. I still am getting called unimplemented OpenGL ES API (as you stated above, it is a different issue).

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 18, 2015

Member

This PR has been added to my merge list, meaning it will be merged into 2.3.x soon, unless someone raises any concerns.

Member

eXpl0it3r commented May 18, 2015

This PR has been added to my merge list, meaning it will be merged into 2.3.x soon, unless someone raises any concerns.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r May 22, 2015

Member

Merged in 717bd85 on branch 2.3.x

Member

eXpl0it3r commented May 22, 2015

Merged in 717bd85 on branch 2.3.x

@eXpl0it3r eXpl0it3r closed this May 22, 2015

@eXpl0it3r eXpl0it3r deleted the bugfix/android_audio_load branch May 22, 2015

@eXpl0it3r eXpl0it3r added this to Done in Android Backlog Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment