New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clear bug on RenderTextures #915

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@Kipernal
Contributor

Kipernal commented Jun 26, 2015

Based on http://en.sfml-dev.org/forums/index.php?topic=18428.0.

Certain drivers seem to ignore requests to clear RenderTextures under certain circumstances. Seems to be related to #591, which fixed part of the problem. This fixes another part (hopefully the rest!).

@binary1248 binary1248 added this to the 2.3.2 milestone Jun 27, 2015

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Jul 4, 2015

Member

Before this becomes a cold PR, can someone test/approve it so that we can remove this undecided flag? :-)

Member

mantognini commented Jul 4, 2015

Before this becomes a cold PR, can someone test/approve it so that we can remove this undecided flag? :-)

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Jul 11, 2015

Member

Could you squash the commits, @Kipernal?

Member

eXpl0it3r commented Jul 11, 2015

Could you squash the commits, @Kipernal?

@eXpl0it3r eXpl0it3r added s:accepted and removed s:undecided labels Jul 11, 2015

@Kipernal

This comment has been minimized.

Show comment
Hide comment
@Kipernal

Kipernal Jul 13, 2015

Contributor

Good catch on the braces. I think I squashed the commits correctly--please let me know if there's anything else I can do.

Contributor

Kipernal commented Jul 13, 2015

Good catch on the braces. I think I squashed the commits correctly--please let me know if there's anything else I can do.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Jul 13, 2015

Member

Well the idea of squashing the commits is usually to just have one commit and one commit message and not really to include all the commit messages of the squad commits as new commit message. 😄

Guess you could just do git commit --amend and edit the message to have one message that describes what you did.

But if it's too complicated it can also be merged like that.

Member

eXpl0it3r commented Jul 13, 2015

Well the idea of squashing the commits is usually to just have one commit and one commit message and not really to include all the commit messages of the squad commits as new commit message. 😄

Guess you could just do git commit --amend and edit the message to have one message that describes what you did.

But if it's too complicated it can also be merged like that.

@Kipernal

This comment has been minimized.

Show comment
Hide comment
@Kipernal

Kipernal Jul 13, 2015

Contributor

Whoops...that was just the default Git used. My mistake--hopefully this message is a bit less useless.

Contributor

Kipernal commented Jul 13, 2015

Whoops...that was just the default Git used. My mistake--hopefully this message is a bit less useless.

@eXpl0it3r eXpl0it3r self-assigned this Jul 13, 2015

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Jul 13, 2015

Member

Thanks!

This PR has been added to my merge list, meaning it will be merged soon into the 2.3.x branch, unless someone raises any concerns.

Member

eXpl0it3r commented Jul 13, 2015

Thanks!

This PR has been added to my merge list, meaning it will be merged soon into the 2.3.x branch, unless someone raises any concerns.

Show outdated Hide outdated include/SFML/Graphics/Texture.hpp Outdated
@Kipernal

This comment has been minimized.

Show comment
Hide comment
@Kipernal

Kipernal Jul 14, 2015

Contributor

The comment's fixed now. Also made the commit message a bit more accurate while I was at it.

Contributor

Kipernal commented Jul 14, 2015

The comment's fixed now. Also made the commit message a bit more accurate while I was at it.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 4, 2015

Member

Merged in f6020c5 on branch 2.3.x

Member

eXpl0it3r commented Aug 4, 2015

Merged in f6020c5 on branch 2.3.x

@eXpl0it3r eXpl0it3r closed this Aug 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment