New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to Xlib event handling #934

Merged
merged 1 commit into from Aug 12, 2015

Conversation

Projects
None yet
4 participants
@binary1248
Member

binary1248 commented Jul 31, 2015

XCB event handling just breaks too many things.

  • Breaks X input method
  • Breaks DRI2 buffer swap and invalidate messages
  • Breaks subtle interaction with X Shape events that might be important in some window managers
  • Breaks integration with other toolkits that still use Xlib events
  • Does not automatically handle keyboard layout changes

The only thing this PR changes is the event queue owner. Even within the switch cases, the events are still handled using XCB, so the changeset is kept relatively small and there are no disadvantages that would have been the case had Xlib been used everywhere.

This fixes among other things #908 and this.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Jul 31, 2015

Member

Sounds fair. Any Linux users who could test this?

Member

eXpl0it3r commented Jul 31, 2015

Sounds fair. Any Linux users who could test this?

@victorlevasseur

This comment has been minimized.

Show comment
Hide comment
@victorlevasseur

victorlevasseur Aug 2, 2015

Contributor

Tested on Fedora 22. The integration with GTK+ works perfectly now (was not the case in 2.3/2.3.1).

Contributor

victorlevasseur commented Aug 2, 2015

Tested on Fedora 22. The integration with GTK+ works perfectly now (was not the case in 2.3/2.3.1).

@TankOs

This comment has been minimized.

Show comment
Hide comment
@TankOs

TankOs Aug 3, 2015

Member

Tested on Arch Linux w/Awesome WM. All examples work. 👍 🐈

Member

TankOs commented Aug 3, 2015

Tested on Arch Linux w/Awesome WM. All examples work. 👍 🐈

@TankOs

This comment has been minimized.

Show comment
Hide comment
@TankOs

TankOs Aug 3, 2015

Member

Btw, can we set this to 2.3.2?

Member

TankOs commented Aug 3, 2015

Btw, can we set this to 2.3.2?

@eXpl0it3r eXpl0it3r added this to the 2.3.2 milestone Aug 3, 2015

@eXpl0it3r eXpl0it3r added the s:accepted label Aug 3, 2015

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 4, 2015

Member

This PR has been added to my merge list, meaning it will be merged soon into the branch 2.3.x, unless someone raises any concerns.

Member

eXpl0it3r commented Aug 4, 2015

This PR has been added to my merge list, meaning it will be merged soon into the branch 2.3.x, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r merged commit fa1bc73 into 2.3.x Aug 12, 2015

0 of 2 checks passed

sfml-debian-64-gcc Build #250 in progress...
Details
sfml-ubuntu-64-gcc Build #100 in progress...
Details

@eXpl0it3r eXpl0it3r deleted the bugfix/xlib_events branch Aug 12, 2015

eXpl0it3r added a commit that referenced this pull request Aug 12, 2015

eXpl0it3r added a commit that referenced this pull request Aug 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment