New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _NET_WM_PING messages not being replied to properly. #947

Merged
merged 1 commit into from Aug 19, 2015

Conversation

Projects
None yet
3 participants
@binary1248
Member

binary1248 commented Aug 16, 2015

Constructing and sending an XCB reply to a _NET_WM_PING doesn't seem to work when using the Xlib event queue so we just resort to sending back the message with the necessary modification using XSendEvent.

Fixes the application being flagged as unresponsive after some time in window managers that support the feature. See this and this.

@binary1248 binary1248 self-assigned this Aug 16, 2015

@binary1248 binary1248 added this to the 2.3.2 milestone Aug 16, 2015

@TankOs

This comment has been minimized.

Show comment
Hide comment
@TankOs

TankOs Aug 16, 2015

Member

👍

Member

TankOs commented Aug 16, 2015

👍

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Aug 17, 2015

Member

This PR has been added to my merge list, meaning it will be merged soon into the 2.3.x branch, unless someone raises any concerns.

Member

eXpl0it3r commented Aug 17, 2015

This PR has been added to my merge list, meaning it will be merged soon into the 2.3.x branch, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r merged commit d53a697 into 2.3.x Aug 19, 2015

15 checks passed

sfml-debian-64-gcc Build #263 succeeded in 1 min 22 sec
Details
sfml-ubuntu-64-gcc Build #113 succeeded in 1 min 49 sec
Details
sfml-windows7-32-mingw492 Build #201 succeeded in 1 min 10 sec
Details
sfml-windows7-32-msvc10 Build #182 succeeded in 1 min 40 sec
Details
sfml-windows7-32-msvc11 Build #178 succeeded in 2 min 50 sec
Details
sfml-windows7-32-msvc12 Build #176 succeeded in 1 min 57 sec
Details
sfml-windows7-32-tdm471 Build #180 succeeded in 5 min 42 sec
Details
sfml-windows7-32-tdm481 Build #176 succeeded in 1 min 14 sec
Details
sfml-windows7-64-mingw492 Build #187 succeeded in 1 min 12 sec
Details
sfml-windows7-64-msvc10 Build #178 succeeded in 1 min 22 sec
Details
sfml-windows7-64-msvc11 Build #176 succeeded in 4 min 20 sec
Details
sfml-windows7-64-msvc12 Build #190 succeeded in 1 min 50 sec
Details
sfml-windows7-64-tdm471 Build #177 succeeded in 4 min 25 sec
Details
sfml-windows7-64-tdm481 Build #194 succeeded in 1 min 25 sec
Details
test Build #91 succeeded in 1 min 44 sec
Details

@eXpl0it3r eXpl0it3r deleted the bugfix/wm_ping branch Aug 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment