New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved memory management on OS X #962

Merged
merged 1 commit into from Sep 27, 2015

Conversation

Projects
None yet
2 participants
@mantognini
Member

mantognini commented Sep 8, 2015

Fixes for #790.

The three bug reports associated with #790 were tested and now run fine but more testing by other people would be nice since it may impact more than just context destructions (leaks, ...).

@mantognini mantognini self-assigned this Sep 8, 2015

@mantognini mantognini added this to the 2.3.3 milestone Sep 13, 2015

@eXpl0it3r eXpl0it3r modified the milestones: 2.4, 2.3.3 Sep 16, 2015

@mantognini mantognini added s:accepted and removed s:undecided labels Sep 21, 2015

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Sep 21, 2015

Member

This patch was tested by two other persons so I'm moving it to 'accepted'. I suggest we move on and merge it.

Member

mantognini commented Sep 21, 2015

This patch was tested by two other persons so I'm moving it to 'accepted'. I suggest we move on and merge it.

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 21, 2015

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Sep 21, 2015

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Sep 25, 2015

Member

Minor: I just realised that I included assert.h instead of cassert. Now it's fixed.

Member

mantognini commented Sep 25, 2015

Minor: I just realised that I included assert.h instead of cassert. Now it's fixed.

@eXpl0it3r eXpl0it3r merged commit 0c9ce3b into master Sep 27, 2015

16 checks passed

sfml-debian-64-gcc Build #323 succeeded in 1 min 24 sec
Details
sfml-osx Build #190 succeeded in 2 min 58 sec
Details
sfml-ubuntu-64-gcc Build #177 succeeded in 1 min 51 sec
Details
sfml-windows7-32-mingw492 Build #262 succeeded in 3 min 36 sec
Details
sfml-windows7-32-msvc10 Build #242 succeeded in 3 min 31 sec
Details
sfml-windows7-32-msvc11 Build #238 succeeded in 4 min 40 sec
Details
sfml-windows7-32-msvc12 Build #234 succeeded in 4 min 8 sec
Details
sfml-windows7-32-tdm471 Build #238 succeeded in 5 min 33 sec
Details
sfml-windows7-32-tdm481 Build #236 succeeded in 3 min 28 sec
Details
sfml-windows7-64-mingw492 Build #247 succeeded in 4 min 43 sec
Details
sfml-windows7-64-msvc10 Build #239 succeeded in 3 min 33 sec
Details
sfml-windows7-64-msvc11 Build #234 succeeded in 4 min 43 sec
Details
sfml-windows7-64-msvc12 Build #251 succeeded in 4 min 22 sec
Details
sfml-windows7-64-tdm471 Build #233 succeeded in 6 min 20 sec
Details
sfml-windows7-64-tdm481 Build #252 succeeded in 4 min 19 sec
Details
test Build #156 succeeded in 1 min 48 sec
Details

@eXpl0it3r eXpl0it3r deleted the bugfix/autoreleasepool branch Sep 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment