New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for VS 2015. #972

Merged
merged 1 commit into from Sep 30, 2015

Conversation

Projects
None yet
4 participants
@eXpl0it3r
Member

eXpl0it3r commented Sep 23, 2015

After a lot of fiddling, I think/hope that all the issues are gone now.

@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Sep 25, 2015

Member

Great, I can confirm that it works! 😀

Why is the directory called libs-msvc-universal? Isn't that misleading if it only works for versions >= 14 (VS 2015)? Or if it is actually universal, why keep the old directory?

Member

Bromeon commented Sep 25, 2015

Great, I can confirm that it works! 😀

Why is the directory called libs-msvc-universal? Isn't that misleading if it only works for versions >= 14 (VS 2015)? Or if it is actually universal, why keep the old directory?

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 25, 2015

Member

Because the new CRT is called Universal CRT and they are not compatible with the old Visual Studio CRT.

Member

eXpl0it3r commented Sep 25, 2015

Because the new CRT is called Universal CRT and they are not compatible with the old Visual Studio CRT.

@Bromeon

This comment has been minimized.

Show comment
Hide comment
@Bromeon

Bromeon Sep 25, 2015

Member

Ah, that makes it clear, thanks!

Member

Bromeon commented Sep 25, 2015

Ah, that makes it clear, thanks!

@eXpl0it3r eXpl0it3r added this to the 2.4 milestone Sep 29, 2015

@eXpl0it3r eXpl0it3r self-assigned this Sep 29, 2015

@eXpl0it3r eXpl0it3r added s:accepted and removed s:undecided labels Sep 29, 2015

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 29, 2015

Member

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Sep 29, 2015

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

@eXpl0it3r eXpl0it3r merged commit 6b97814 into master Sep 30, 2015

16 checks passed

sfml-debian-64-gcc Build #334 succeeded in 1 min 27 sec
Details
sfml-osx Build #207 succeeded in 2 min 52 sec
Details
sfml-ubuntu-64-gcc Build #188 succeeded in 1 min 51 sec
Details
sfml-windows7-32-mingw492 Build #272 succeeded in 1 min 7 sec
Details
sfml-windows7-32-msvc10 Build #252 succeeded in 2 min 3 sec
Details
sfml-windows7-32-msvc11 Build #249 succeeded in 2 min 4 sec
Details
sfml-windows7-32-msvc12 Build #244 succeeded in 4 min 15 sec
Details
sfml-windows7-32-tdm471 Build #248 succeeded in 3 min 5 sec
Details
sfml-windows7-32-tdm481 Build #246 succeeded in 1 min 13 sec
Details
sfml-windows7-64-mingw492 Build #257 succeeded in 1 min 25 sec
Details
sfml-windows7-64-msvc10 Build #249 succeeded in 2 min 4 sec
Details
sfml-windows7-64-msvc11 Build #243 succeeded in 5 min 10 sec
Details
sfml-windows7-64-msvc12 Build #261 succeeded in 4 min 37 sec
Details
sfml-windows7-64-tdm471 Build #243 succeeded in 3 min 11 sec
Details
sfml-windows7-64-tdm481 Build #262 succeeded in 1 min 29 sec
Details
test Build #167 succeeded in 1 min 49 sec
Details

@eXpl0it3r eXpl0it3r deleted the feature/vs2015 branch Sep 30, 2015

@Cleroth

This comment has been minimized.

Show comment
Hide comment
@Cleroth

Cleroth Oct 1, 2015

Thank you. 👍 Appreciate this.

Cleroth commented on 6b97814 Oct 1, 2015

Thank you. 👍 Appreciate this.

This comment has been minimized.

Show comment
Hide comment
@ricanteja

ricanteja Oct 1, 2015

Contributor

Big thumbs up! 👍

Contributor

ricanteja replied Oct 1, 2015

Big thumbs up! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment