Add .desktop file and placeholder icon.

[boombatower]

When packaging openage it would be nice to have a common .desktop and icon file to use.

[TheJJ]

Oh gaben, bringer of the half life 3, thou thy lordship is perfect for our project, there must not be binary files in the repo where they can be avoided. The clean solution would be to add a install rule that uses imagemagick or similar to cut the already existing gaben image to icon format.

The real logo should be some epic svg so we'll never have to provide higher resolution icons including the day we got 9001k screens.

[boombatower]

I'll look into adding a rule. Also, a preview:

[boombatower]

I recommend that I rebase the branch before it is pulled so there is no copy of binary image in history. Also not sure how close I am with cmake stuff or how to get it included since it does not seem to be executed. I'll leave it here and wait for input.

[mic-e]

Looking forward to the nightlies. Also I love gaben.

However, the dist folder shouldn't be inside assets. Instead, create a folder dist/, with a subfolder opensuse (obviously gaben isn't distribution-specific and should be directly in dist/.

Clarification: the assets folder is for all files that are used by openage at run-time, and is installed to /usr/share/openage.

Avoiding binaries in the git history is indeed a goal.

[TheJJ]

The .desktop file is for all distros, you can place it in dist/openage.desktop i'd say. Distro specific stuff should be put to dist/$distroname/, but we have to condider whether we want to put the package building script in our repo.

I think putting distro build scripts into the repo is a bad idea and shouldn't be done. The files will outdate and just clobber the repo, instead we could create a new repo where distroscript are stored in.

Don't misunderstand me, packaging related files like the .desktop is suited for all distros and can be put inside the repo.

[zuntrax]

You should also add ImageMagick to the dependencies in building.md

[TheJJ]

Ugh, another dependency... I hope we could avoid that somehow, especially as other platforms might have difficulties with using or having imagemagick available.

[LordAro]

I see no issue with storing images in the repo, if they're necessary

[phrohdoh]

OS X can get ImageMagick easily through Homebrew, but not all users will want to go that route.

[mic-e]

We do have PIL as a depend, right? Maybe some 5-line python script could duplicate the imagemagick functionality?

import PIL.Image
file=PIL.Image.open('/home/mic/git/openage/assets/gaben.png')
file.resize((24, 24), PIL.Image.ANTIALIAS).save('/tmp/tinygaben.png')

Sorry, 3 lines, actually.

[TheJJ]

very good idea, that should be the way to go.

[boombatower]

Can someone point me to how I need to hook up cmake stuff (per my 3rd comment). It doesn't seem my CMakeLists.txt is invoked. I imagine I have to hook it up somewhere. I think having dist just contain files needed is fine unless we find a reason to include distro specific stuff.

Moved the rest of this comment to #94.

[franciscod]

@boombatower take a look at this: https://github.com/franciscod/openage/commit/953d7471ebd0e98a93d27dc3ec3fb342ba4d9231

it still depends on imagemagick

[franciscod]

no imagemagick here: https://github.com/franciscod/openage/commit/5637d90f0280e8f5964d10eafe81b7656c094a97

[boombatower]

lol excellent commit messages look ma, no imagemagick!

Thanks I'll get it fixed up and assume we should put final version in /dist as discussed.

[franciscod]

hahaha glad you liked it

[boombatower]

What I currently see is:

Cropping gaben.png to create placeholder desktop icon...
Traceback (most recent call last):
  File "<string>", line 4, in <module>
  File "/usr/lib64/python3.3/site-packages/PIL/Image.py", line 1558, in save
    fp = builtins.open(fp, "wb")
FileNotFoundError: [Errno 2] No such file or directory: '/home/boombatower/openage/.bin/gcc-release-O2/dist/openage.png'

Creating dist/ in main tree doesn't seem to help. Otherwise all the cmake stuff runs!

[franciscod]

what if you do ls /home/boombatower/openage/.bin/gcc-release-O2/ ? my guess is that dist/ doesn't exist :)

[franciscod]

@TheJJ: "The real logo should be some epic svg so we'll never have to provide higher resolution icons including the day we got 9001k screens."

MSG   ERROR: Could not load texture from 'assets/gaben.svg': Unsupported image format
FATAL Exception: Could not load texture from 'assets/gaben.svg': Unsupported image format

NOOOOOOOOOOOOOOOOOOOOOOOOO 😢

[boombatower]

Nothing there, no dist/. That's where I looked before as I printed out the path.

$ ls -l /home/boombatower/openage/.bin/gcc-release-O2/
total 100
drwxr-xr-x  3 boombatower users  4096 Nov  2 22:41 assets
drwxr-xr-x  4 boombatower users  4096 Nov  2 22:47 build
-rw-r--r--  1 boombatower users 30935 Nov  2 22:41 CMakeCache.txt
drwxr-xr-x 35 boombatower users  4096 Nov  2 22:47 CMakeFiles
-rw-r--r--  1 boombatower users  3136 Nov  2 22:32 cmake_install.cmake
-rw-r--r--  1 boombatower users  3871 Nov  2 22:47 codegen_depend_cache
-rw-r--r--  1 boombatower users  1589 Nov  2 22:47 codegen_target_cache
-rw-r--r--  1 boombatower users     0 Nov  2 22:47 codegen_timefile
drwxr-xr-x 12 boombatower users  4096 Nov  2 22:47 cpp
-rw-r--r--  1 boombatower users   324 Nov  2 22:32 CTestTestfile.cmake
-rw-r--r--  1 boombatower users  2236 Oct 26 23:02 DartConfiguration.tcl
-rw-r--r--  1 boombatower users 21222 Nov  2 22:41 Makefile
drwxr-xr-x  4 boombatower users  4096 Nov  2 22:47 py
drwxr-xr-x  3 boombatower users  4096 Oct 26 23:02 Testing

[franciscod]

You can add a line to your CMakeLists.txt:

file(MAKE_DIRECTORY ${CMAKE_BINARY_DIR}/dist)

maybe this is redundant... but it'll work

[boombatower]

Was wondering if something like that was needed (worked). Ok, I'll clean this up and get things moved around. Also rebase to get rid of image file in history.

[boombatower]

Alight, completed all the polishing. Rebased so squash all commits together so the image disappears entirely. :) I'll need to update packaging to use this once merged.

@franciscod Thanks again for assistance.

[boombatower]

Also preemptively added quotes per #92.

[franciscod]

you're welcome! (hi welcome, i'm franciscod! (?))

[TheJJ]

LOL @ svg-gaben.

The icon generation looks ok for now. The desktop-file will be non-functional of course as ~/.openage will not be created by make media by default, a manual conversion call will be necessary.

But, i'd say this is good for the first try, 👍.

[boombatower]

Per, other issues I have updated .desktop file as follows (rebased to keep ready):

diff --git a/dist/openage.desktop b/dist/openage.desktop
index 5c3c822..e52e180 100644
--- a/dist/openage.desktop
+++ b/dist/openage.desktop
@@ -1,8 +1,10 @@
+#!/usr/bin/env xdg-open
 [Desktop Entry]
 Name=openage
 Comment=Free engine clone of Age of Empires II
-Exec=openage --data="~/.openage/assets" %u
-Terminal=false
+Exec=openage --data=assets %u
+Path=~/.openage/
+Terminal=true
 Type=Application
 Icon=openage
 Categories=Game;StrategyGame;

[TheJJ]

when i take another look at it, it seems to be more suitable if the CMakeLists.txt for the icon conversion would be placed to dist/, do you agree?

[franciscod]

wow, does github autoformat diffs in that way on markdown triple backtick blocks?

[phrohdoh]

@franciscod yes if you use ```diff

[franciscod]

thanks @phrohdoh!

[boombatower]

Placed CMakeLists.txt in dist.

[mic-e]

👍 (once that grammar issue is fixed)

[boombatower]

should be good to go

[boombatower]

Just look at gaben looking down over the glory that is openage.

[charego]

Thanks for the fix.

[boombatower]

👍