Add is_complete() to UniformInput and Implement Checks in Demos

[ZzzhHe]

Hi, This is my first PR! Issue resolve #1681

This PR introduces a virtual is_complete() method to UniformInput, with an override in GlUniformInput to validate that all required uniform values are set.

I'm currently a bit unsure about the optimal place to call is_complete() in the demos. Here are the options I'm considering:

• After Creation by new_uniform_input(): Might miss uniforms that are added later using the update() method.
• After Every update(): This could introduce unnecessary overhead, especially if updates occur frequently.
• Before Rendering: Might not catch updates made inside the rendering loop.

I'm looking forward to any feedback!

[TheJJ]

the duplication in each demo/usage to check for the errors should be optimized away, it would be better to check at a place all of them invoke anyway.

[ZzzhHe]

the duplication in each demo/usage to check for the errors should be optimized away, it would be better to check at a place all of them invoke anyway.

Thanks! I've added a check_uniform_completeness() function that checks all uniforms by iterating over the Renderable objects.

[heinezen]

Very nice! I recommend you use clang-format on all files to solve your style issues.

[ZzzhHe]

Very nice! I recommend you use clang-format on all files to solve your style issues.

Thanks! I’ve formatted the files with clang-format. Also, I used a rebase to remove the two files that didn’t need changes, so I had to force-push.

[ZzzhHe]

BTW, I noticed some code in the demo files is still using ! instead of not. Should I go ahead and change that?

[heinezen]

@ZzzhHe yes please :)

[ZzzhHe]

@ZzzhHe yes please :)

done.

[TheJJ]

i think there's a better way to place the completeness check - in the renderer when a render pass is created.

[TheJJ]

this means we need to copy the renderables into the vector, which we don't need :)
you can convert the type to const std::vector<Renderable &> &renderables.
if this is known at compiletime, you can do it even better by using a variadic template.

on another note: this is useful not only for the demos, but for the renderer in general. so it should be put outside the demo directory.

[TheJJ]

as you see above, the render pass stores the exact same renderables, so the render pass can get the feature to check if all its uniform inputs are complete.
when the render pass is added to the renderer, the check can be invoked there directly, i think.

[heinezen]

@TheJJ It should not be done in the renderer itself because we might get a bunch problems. We would no longer be able to make partial uniform updates for shaders (e.g. with ShaderUpdate). Also, the uniforms may not be initialized when the render pass is created. Uniform initialization should be deferrable for optimization purposes, so that we can create a bunch of render objects without waiting for updates from the gamestate.

I actually just wanted this function for debugging because uninitialized uniform values are really hard to detect :D But they are not necessary for the general workflow I think.

We discussed the reasons for not doing the check inside the renderer in #1718 (comment)