Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound: Master Volume not working #119

Closed
jfgilliam opened this issue Sep 1, 2017 · 1 comment

Comments

@jfgilliam
Copy link
Contributor

commented Sep 1, 2017

Changing the master volume (sound-volume) in the settings to a value greater than 1 but less than 100 causes errors from the sound card saying that it's too high. That's because it expects values between 0.0 and 1.0. I will be fixing the code to check the maximum and not allow it to try to set it above it. I will also change the code to allow the range to be between 0 and 100 like the other volumes.

Thanks to Zack Brew for finding this.

The workaround is to keep the value between 0.0 and 1.0.

@jfgilliam jfgilliam self-assigned this Sep 1, 2017

@jfgilliam jfgilliam added this to the Version 1.4 milestone Sep 1, 2017

jfgilliam added a commit to SIMRacingApps/SIMRacingAppsServer that referenced this issue Sep 8, 2017

Fixed #119 (SIMRacingApps/SIMRacingApps#119)
       Sound: Master Volume not working

@jfgilliam jfgilliam closed this in 56be1c8 Sep 8, 2017

@jfgilliam

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.