Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Attack: Announce times as Minutes and Seconds when over 59s #92

Closed
samkatakouzinosracing opened this issue Feb 22, 2017 · 5 comments
Closed

Comments

@samkatakouzinosracing
Copy link

@samkatakouzinosracing samkatakouzinosracing commented Feb 22, 2017

I would like announced times to be expressed as minutes and seconds when time value is over 59 seconds.

I would prefer to hear 'Leader is 2 minute, 15 seconds ahead' rather than 'Leader is 135 seconds ahead'.

@jfgilliam jfgilliam changed the title Announce times as Minutes and Seconds when over 59s Voice Attack: Announce times as Minutes and Seconds when over 59s Feb 22, 2017
@jfgilliam jfgilliam self-assigned this Feb 22, 2017
@jfgilliam jfgilliam added this to the Version 1.2 milestone Feb 22, 2017
@jfgilliam
Copy link
Contributor

@jfgilliam jfgilliam commented Mar 9, 2017

I changed Ahead/Behind to be for all classes. Got rid of Ahead/Behind Relative and replaced them with Ahead/Behind Class. These now all say the times in minutes (if greater than zero) and Seconds. Let me how it goes and I'll put it in the next release.

Loading

@jfgilliam
Copy link
Contributor

@jfgilliam jfgilliam commented Mar 11, 2017

Added some more chat commands (Thanks, You're Welcome, Pitting In, Pitting Out)

Loading

@jfgilliam
Copy link
Contributor

@jfgilliam jfgilliam commented Mar 13, 2017

Fixed a rounding error where anything greater than 30 seconds on the minute, would round the minutes up.

Loading

@samkatakouzinosracing
Copy link
Author

@samkatakouzinosracing samkatakouzinosracing commented Mar 14, 2017

Entered a session and the quickest lap time of 1:16.725 was spoken as "minus {short blank space) 16.725 seconds ahead".
The minutes part was missing?

Loading

@jfgilliam
Copy link
Contributor

@jfgilliam jfgilliam commented Mar 14, 2017

OK, I tried a different approach on the rounding. Try this one out.

SIMRacingApps-VoiceAttack-Profile.zip

Loading

@jfgilliam jfgilliam closed this in 5bcc867 Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants