Skip to content

fix: misleading inspection text on RuntimeDirectory #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2024
Merged

fix: misleading inspection text on RuntimeDirectory #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...intellij/plugins/systemdunitfiles/semanticdata/optionvalues/ExecDirectoriesOptionValue.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class ExecDirectoriesOptionValue : OptionValueInformation {
// loop over element in values
for (element in values) {
if (element.startsWith("/")) {
return "Invalid path: '${element}'. Takes a list of absolute paths."
return "Invalid path: '${element}'. Takes a list of relative paths."
} else if (element.contains("..")) {
return "Invalid path: '${element}'. Path cannot contain `..`."
}
Expand Down
4 changes: 2 additions & 2 deletions ...ugins/systemdunitfiles/inspections/InvalidValueInspectionForExecDirectoriesOptionsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class InvalidValueInspectionForExecDirectoriesOptionsTest : AbstractUnitFileTest
// Verification
assertSize(1, highlights)
val info = highlights[0]
AbstractUnitFileTest.Companion.assertStringContains("Takes a list of absolute paths", info!!.description)
AbstractUnitFileTest.Companion.assertStringContains("a list of relative paths", info!!.description)
TestCase.assertEquals("/tmp/myunit", info.text)
}

Expand All @@ -84,7 +84,7 @@ class InvalidValueInspectionForExecDirectoriesOptionsTest : AbstractUnitFileTest
// Verification
assertSize(1, highlights)
val info = highlights[0]
AbstractUnitFileTest.Companion.assertStringContains("Takes a list of absolute paths", info!!.description)
AbstractUnitFileTest.Companion.assertStringContains("Takes a list of relative paths", info!!.description)
TestCase.assertEquals("/tmp/myunit /tmp/myunit2", info.text)
}

Expand Down