Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizer grid #21

Merged
merged 6 commits into from Sep 17, 2019

Conversation

@Zephyril
Copy link
Member

commented Sep 10, 2019

Regarding #7.

Zephyril added 3 commits Sep 9, 2019
Merge pull request #19 from SMHacks/master
Updating my branch

@smartspot2 smartspot2 added this to Pull/Merge Requests in SM Hacks III Website via automation Sep 11, 2019

@smartspot2 smartspot2 self-requested a review Sep 11, 2019

@smartspot2
Copy link
Collaborator

left a comment

The grid looks pretty good overall; I think some animation on hover with the images would be nice, though it would cause the user to want to click on the headshots.

If you're gonna add animation, I suggest you add a modal that pops up onclick of the headshot, displaying contact info, bio maybe, etc.

I can do that if you want, though after my pull request is approved, the tedious part should be resolved and you should just be able to use bootstrap's default modal and everything should work fine.

Otherwise, everything looks nice!

// $('#top-button').css('box-shadow', 'none');
// }
//
// });

This comment has been minimized.

Copy link
@smartspot2

smartspot2 Sep 11, 2019

Collaborator

Need newline at end of file (just press CTRL-SHIFT-L in webstorm to automatically format a file)

.text-center {
text-align: center;
}

This comment has been minimized.

Copy link
@smartspot2

smartspot2 Sep 11, 2019

Collaborator

Bootstrap already has a .text-center class, so you don't need these lines here.

@Zephyril Zephyril merged commit e07a356 into master Sep 17, 2019

SM Hacks III Website automation moved this from Pull/Merge Requests to Merged Pull Requests Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.