Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated integration test #207

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Remove outdated integration test #207

merged 3 commits into from
Sep 20, 2022

Conversation

JostMigenda
Copy link
Member

This fixes a minor oversight in #193 by removing a test script used to test the snewpy.snowglobes_interface.SNOwGLoBES class that was now removed. It also simplifies the GitHub integration test workflow.

@github-actions
Copy link

github-actions bot commented Sep 12, 2022

Result of Benchmark Tests

Benchmark Min Max Mean
python/snewpy/test/test_snowglobes.py::test_simulation_chain_benchmark 5.24 5.42 5.35 +- 0.08

This was only used to generate an input file for GLoBES
@JostMigenda JostMigenda added this to the v1.3 milestone Sep 15, 2022
@mcolomermolla
Copy link
Collaborator

After reviewing it, I don't see any reason why this PR shouldn't be merged. The changes made are straightforward after removing globes.

@JostMigenda
Copy link
Member Author

Thanks for checking @mcolomermolla!

@JostMigenda JostMigenda merged commit 7aed43d into main Sep 20, 2022
@JostMigenda JostMigenda deleted the JostMigenda/v1.3b1 branch September 20, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants