Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples grid and Basic Export do not contain information about the sample's district for samples associated with event participants [1] #12940

Closed
3 tasks
adinaflorea9 opened this issue Feb 6, 2024 · 2 comments · Fixed by #12946
Assignees
Labels
android-app Affects the Android app change A change of an existing feature (ticket type) import-export laboratory Samples, pathogen tests and lab messages qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application

Comments

@adinaflorea9
Copy link

adinaflorea9 commented Feb 6, 2024

Problem Description

For samples associated with event participants, the display of the district in the samples grid and in the Basic Export is not done or the district of the event is displayed instead of the one from the event participant.

The mobile app grid should also be checked and considered when making the changes.

Proposed Change

For samples associated with event participants, display in the grid and in the basic export the district associated with the event participant.

Added Value/Benefit

Consistency in the way information is displayed in the grid and exports.

Acceptance Criteria

  • when both the event and the event participant have information regarding the region and district, the information from the event participant page should come first (be displayed in the samples grid and basic export);
  • when only the event participant has region and district, the information should be displayed in the samples grid and the basic export;
  • when only the event has region and district, the information should continue to be displayed in the samples grid and basic export;

Implementation Details

No response

Mockups

No response

Additional Information

No response

@adinaflorea9 adinaflorea9 added android-app Affects the Android app laboratory Samples, pathogen tests and lab messages vaadin-app Affects the Vaadin application import-export change A change of an existing feature (ticket type) ready Issue fulfills the definition of ready and can be implemented labels Feb 6, 2024
@carina29 carina29 self-assigned this Feb 6, 2024
@carina29 carina29 changed the title Samples grid and Basic Export do not contain information about the sample's district for samples associated with event participants Samples grid and Basic Export do not contain information about the sample's district for samples associated with event participants [2] Feb 6, 2024
@carina29
Copy link
Contributor

carina29 commented Feb 7, 2024

There will be a corner case when in the Event Participant form only the Region is filled (the district is left empty).
In basic export and grid right now is checked if the event participant district field is filled ( if yes this will be added if not the district from the event will be added).
image

image
As an outcome in this scenario will appear the district from the Event.
I've talked with @adinaflorea9 and she agreed that it would be ok to leave the district from the event rather than leaving it empty.
@MateStrysewske Would be ok for you too or should I change to have same behaviour with the one from Detailed export ( I've explained below the behaviour from Detailed export)?

Note:
In case of detailed export (#11551) I've checked if the eventParticipantJurisdictionData is filled or not based on the eventParticipantRegion. Based on this principle, in the Samples grid and Basic export the District field should remain empty.

@carina29 carina29 changed the title Samples grid and Basic Export do not contain information about the sample's district for samples associated with event participants [2] Samples grid and Basic Export do not contain information about the sample's district for samples associated with event participants [1] Feb 7, 2024
MateStrysewske added a commit that referenced this issue Feb 12, 2024
…ict_of_event_participant_in_samples_grid

#12940 - Display the event participant's district
@adinaflorea9 adinaflorea9 self-assigned this Feb 12, 2024
@adinaflorea9
Copy link
Author

Verified ticket on the local machine using the latest version of SORMAS from the development branch - 1.95.0-SNAPSHOT(0799a1f).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-app Affects the Android app change A change of an existing feature (ticket type) import-export laboratory Samples, pathogen tests and lab messages qa-verified Issue has been tested and verified by QA ready Issue fulfills the definition of ready and can be implemented vaadin-app Affects the Vaadin application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants