Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cover getMany and create for partners entity #154

Merged
merged 6 commits into from
May 23, 2024

Conversation

BertBR
Copy link
Contributor

@BertBR BertBR commented May 20, 2024

  • Melhora a cobertura de testes para a entidade Partner

@rodrigooler rodrigooler added the enhancement New feature or request label May 20, 2024
Copy link
Contributor

@rodrigooler rodrigooler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BertBR, você poderia adicionar alguns casos de uso com dados mockados para verificar o retorno e a validação? Também seria útil incluir cenários em que o código de criação possa falhar e retornar os erros esperados.

@BertBR BertBR requested a review from rodrigooler May 20, 2024 23:32
src/partners/partners.service.spec.ts Outdated Show resolved Hide resolved
src/partners/partners.service.spec.ts Outdated Show resolved Hide resolved
@BertBR BertBR requested a review from giggio May 21, 2024 02:36
@BertBR
Copy link
Contributor Author

BertBR commented May 22, 2024

PR fechada pelo mesmo motivo dessa outra: #159

@BertBR BertBR closed this May 22, 2024
@giggio giggio reopened this May 23, 2024
@giggio
Copy link
Member

giggio commented May 23, 2024

@BertBR eu gostaria de integrar isso aí, vou revisar suas alterações.

Copy link
Member

@giggio giggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agora está ok, bora integrar.

@giggio giggio merged commit bc100dd into SOS-RS:develop May 23, 2024
2 checks passed
@BertBR BertBR deleted the test/partners branch May 23, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Entregue (Po + Dev + Infra)
Development

Successfully merging this pull request may close these issues.

3 participants