refactor(music-cache): 模糊匹配时按音质优先级自动选择最佳缓存 by laoshuikaixue · Pull Request #1009 · SPlayer-Dev/SPlayer

laoshuikaixue · 2026-03-20T04:30:05Z

添加音质优先级映射表，支持多种音质等级排序
实现 pickCandidates 方法按音质优先级和修改时间选择候选缓存
重构 hasCache 方法支持按音质优先级自动选择最佳缓存

- 添加音质优先级映射表，支持多种音质等级排序 - 实现缓存元数据文件管理，存储MD5和文件大小信息 - 新增getMetaPath、readMeta、writeMeta等元数据操作方法 - 实现pickCandidates方法按音质优先级和修改时间选择候选缓存 - 重构hasCache方法支持按音质优先级自动选择最佳缓存 - 改进MD5验证逻辑，添加元数据缓存减少重复计算 - 优化下载完成后的元数据写入流程

gemini-code-assist · 2026-03-20T04:30:24Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在全面提升音乐缓存服务的智能性和可靠性。通过引入音质优先级管理和独立的缓存元数据文件，系统现在能够更精确地管理和选择缓存的音乐文件，确保用户始终获得最佳音质体验。同时，MD5验证机制得到了显著增强，利用元数据缓存避免了重复计算，从而提高了缓存验证的效率和准确性。

Highlights

音质优先级管理: 添加了音质优先级映射表，支持多种音质等级排序，使得系统能够根据预设权重选择最佳音质缓存。
缓存元数据管理: 实现了缓存元数据文件管理，用于存储MD5和文件大小信息，并新增了 getMetaPath、readMeta、writeMeta 等元数据操作方法。
智能缓存选择: 新增了 pickCandidates 方法，能够根据音质优先级和修改时间智能选择候选缓存。
MD5验证机制优化: 重构了 hasCache 方法，使其支持按音质优先级自动选择最佳缓存，并改进了MD5验证逻辑，利用元数据缓存减少重复计算，提高验证效率。
下载后元数据写入: 优化了下载完成后的元数据写入流程，确保缓存文件的MD5和大小信息及时更新并存储。
环境变量配置: 新增了 .env 文件，用于配置Web和API端口以及API地址。

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

这个 PR 极大地优化了音乐缓存服务，引入了音质优先级和基于元数据的 MD5 校验机制，是非常出色的改进。代码结构清晰，新功能考虑周全。我提出了一些建议，主要集中在错误处理和性能优化方面，希望能让代码更加健壮和高效。

MoYingJi · 2026-03-21T23:28:38Z

你是不是切错分支了（

laoshuikaixue · 2026-03-22T03:54:54Z

应该不影响合并(( 不小心把env传上来了 现在回学校了要等下周再改原始邮件发件人：MoYingJi ***@***.***> 发件时间：2026年3月22日 07:28 收件人：imsyy/SPlayer ***@***.***> 抄送：LaoShui ***@***.***>, Author ***@***.***> 主题：Re: [imsyy/SPlayer] feat(electron): 优化音乐缓存服务的音质优先级和MD5验证机制 (PR #1009) MoYingJi left a comment (SPlayer-Dev/SPlayer#1009) 你是不是切错分支了（ — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

- 添加了精确缓存检查和获取候选缓存的错误捕获及警告日志 - 将元数据写入改为异步执行避免阻塞主流程 - 添加了元数据写入失败的错误处理和警告日志 - 保持了文件重命名和缓存大小记录功能的正常执行

Co-authored-by: MoYingJi <moyingjiaw@outlook.com>

MoYingJi

我不太认同使用 .meta.json 文件存储元数据

我觉得校验哈希并不占太多时间，基本可以忽略不计

# 大小最大的文件
> du -h ./* | sort --numeric-sort | tail -1
92M     ./2630874953_Hi-Res.sc

# 测量时间
> time md5sum 2630874953_Hi-Res.sc
cd7fb8a62ee113b20dc6d6d0d955684a  2630874953_Hi-Res.sc

real    0m0.100s
user    0m0.089s
sys     0m0.011s

即使你认为计算 md5sum 的时间会拖慢缓存检索速度，也可以使用项目已有的数据库存储这些信息，而不是新建一个文件（我相信当时把歌词缓存从 json 文件换成数据库也是有理由的）。现在直接新建了一个 .meta.json 文件，还是和 .sc 混在一起放

- 移除文件系统元数据文件读写，改用缓存服务存储 - 删除不再使用的 getMetaPath 方法 - 更新 readMeta 方法以从缓存中读取元数据 - 修改 writeMeta 方法将元数据写入缓存服务 - 调整 removeCacheWithMeta 方法使用缓存服务删除元数据 - 简化元数据键名生成逻辑

laoshuikaixue · 2026-04-05T12:10:09Z

@gemini-code-assist review

gemini-code-assist

Code Review

This pull request enhances the MusicCacheService by implementing a quality priority system and a more robust cache selection mechanism. When checking for a cache, the service now sorts candidates by audio quality and modification time. The review feedback suggests normalizing quality strings to be case-insensitive, implementing the missing metadata management for MD5 calculation mentioned in the PR description, and optimizing the file listing process to prevent performance degradation.

gemini-code-assist · 2026-04-05T12:12:30Z

+        return filePath;
+      }
+      try {
+        const fileMD5 = await this.calculateMD5(filePath);


PR 描述中提到实现了元数据管理以存储 MD5 并减少重复计算，包括 getMetaPath、readMeta 和 writeMeta 等新方法。然而，当前代码中并未发现这些方法，且 hasCache 在提供 expectedMD5 时仍然通过读取整个文件来计算 MD5。请确保包含元数据缓存逻辑，以避免重复哈希带来的性能开销。

gemini-code-assist · 2026-04-05T12:12:30Z

+  private async pickCandidates(
+    id: number | string,
+  ): Promise<Array<{ filePath: string; quality: string }>> {
+    const items = await this.cacheService.list("music");


在 pickCandidates 中调用 this.cacheService.list("music") 会触发对音乐缓存目录的完整扫描，并对每个文件执行 stat 操作。随着缓存文件数量的增加，这可能会成为显著的性能瓶颈。建议考虑为缓存的音乐文件实现索引（例如在数据库中），以便通过 ID 快速查找，而无需扫描整个文件系统。

- 将音质优先级映射中的键值从大写改为小写 - 修改getQualityWeight方法以支持大小写不敏感的音质匹配 - 确保音质比较时统一转换为小写进行匹配

- 删除了 private removeCacheFile 方法 - 将文件删除逻辑直接内联到调用处 - 保持相同的错误处理行为

MoYingJi

应该差不多了，可以补点注释上去

MoYingJi · 2026-04-05T13:15:42Z

把标题和内容改了下，更符合当前 PR 的更改

- 移除注释中的枚举值兼容性说明 - 统一音质键名的字符串格式 - 删除冗余的音质选项如lossless、flac、exhigh等 - 保留核心音质等级配置 - 优化对象结构提高可读性

MoYingJi · 2026-04-05T13:35:15Z

+  /** 音质优先级 */
+  private readonly qualityPriority: Record<string, number> = {
+    "master": 100,
+    "dolby": 95,
+    "spatial": 90,
+    "surround": 85,
+    "hi-res": 80,
+    "sq": 70,
+    "hq": 60,
+    "mq": 50,
+    "lq": 40,
+    "standard": 40,
+  };


我在思考 master、dolby、spatial、surround 这四个 AI 音质是否要给到更高的优先级，尤其是 dolby（杜比全景声）和 surround（沉浸环绕声）和其它的普通音质都不在一组内了

laoshuikaixue added 19 commits January 9, 2026 18:21

Add environment variables for web and API configuration

d912b46

Update API URL to use HTTPS

c594b9a

Merge branch 'imsyy:dev' into dev

3127911

Merge branch 'imsyy:dev' into dev

b92f26f

Merge branch 'imsyy:dev' into dev

3524cea

Merge branch 'imsyy:dev' into dev

50c66b5

Merge branch 'imsyy:dev' into dev

509351d

Merge branch 'imsyy:dev' into dev

8002e8a

Merge branch 'imsyy:dev' into dev

72d5ad1

Merge branch 'imsyy:dev' into dev

61ea683

Merge branch 'imsyy:dev' into dev

f99027a

Merge branch 'imsyy:dev' into dev

4214d93

Merge branch 'imsyy:dev' into dev

ea6b610

Merge branch 'imsyy:dev' into dev

f91e3fc

Merge branch 'imsyy:dev' into dev

f038cb5

Merge branch 'imsyy:dev' into dev

f611d9c

Update API URL in .env file

36c662f

Merge branch 'imsyy:dev' into dev

1ad9447

gemini-code-assist Bot reviewed Mar 20, 2026

View reviewed changes

Comment thread electron/main/services/MusicCacheService.ts Outdated

Comment thread electron/main/services/MusicCacheService.ts Outdated

Comment thread electron/main/services/MusicCacheService.ts Outdated

MoYingJi marked this pull request as draft March 22, 2026 15:47

config: 移除环境变量配置文件

f9b0b9a

MoYingJi reviewed Apr 5, 2026

View reviewed changes

Comment thread electron/main/services/MusicCacheService.ts Outdated

laoshuikaixue marked this pull request as ready for review April 5, 2026 11:05

MoYingJi reviewed Apr 5, 2026

View reviewed changes

Comment thread electron/main/services/MusicCacheService.ts Outdated

Update electron/main/services/MusicCacheService.ts

0b13f78

Co-authored-by: MoYingJi <moyingjiaw@outlook.com>

MoYingJi reviewed Apr 5, 2026

View reviewed changes

gemini-code-assist Bot reviewed Apr 5, 2026

View reviewed changes

fix(cache): 修复音质优先级匹配问题

e8125b1

- 将音质优先级映射中的键值从大写改为小写 - 修改getQualityWeight方法以支持大小写不敏感的音质匹配 - 确保音质比较时统一转换为小写进行匹配

laoshuikaixue requested a review from MoYingJi April 5, 2026 12:19

MoYingJi reviewed Apr 5, 2026

View reviewed changes

Comment thread electron/main/services/MusicCacheService.ts Outdated

refactor(music-cache): 移除私有缓存文件删除方法并内联实现

5e9431a

- 删除了 private removeCacheFile 方法 - 将文件删除逻辑直接内联到调用处 - 保持相同的错误处理行为

laoshuikaixue requested a review from MoYingJi April 5, 2026 12:45

MoYingJi approved these changes Apr 5, 2026

View reviewed changes

docs: 补充代码注释

522f3e1

MoYingJi changed the title ~~feat(electron): 优化音乐缓存服务的音质优先级和MD5验证机制~~ refactor(music-cache): 模糊匹配时按音质优先级自动选择最佳缓存 Apr 5, 2026

MoYingJi reviewed Apr 5, 2026

View reviewed changes

Comment thread electron/main/services/MusicCacheService.ts Outdated

refactor(music): 简化音质优先级配置

f1e55d2

- 移除注释中的枚举值兼容性说明 - 统一音质键名的字符串格式 - 删除冗余的音质选项如lossless、flac、exhigh等 - 保留核心音质等级配置 - 优化对象结构提高可读性

MoYingJi reviewed Apr 5, 2026

View reviewed changes

apoint123 approved these changes Apr 5, 2026

View reviewed changes

MoYingJi merged commit bea6f8f into SPlayer-Dev:dev Apr 6, 2026

Conversation

laoshuikaixue commented Mar 20, 2026 • edited by MoYingJi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot commented Mar 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MoYingJi commented Mar 21, 2026

Uh oh!

laoshuikaixue commented Mar 22, 2026 via email

Uh oh!

Uh oh!

Uh oh!

MoYingJi left a comment

Choose a reason for hiding this comment

Uh oh!

laoshuikaixue commented Apr 5, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MoYingJi left a comment

Choose a reason for hiding this comment

Uh oh!

MoYingJi commented Apr 5, 2026

Uh oh!

Uh oh!

MoYingJi Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

laoshuikaixue commented Mar 20, 2026 •

edited by MoYingJi

Loading