Skip to content

fix(cache): 修复缓存大小上限默认值处理#645

Merged
imsyy merged 1 commit into
SPlayer-Dev:devfrom
MoYingJi:fix
Dec 21, 2025
Merged

fix(cache): 修复缓存大小上限默认值处理#645
imsyy merged 1 commit into
SPlayer-Dev:devfrom
MoYingJi:fix

Conversation

@MoYingJi
Copy link
Copy Markdown
Collaborator

0 是 falsy 值,使用 || 会导致预期为「不限制」的 0 被设置为默认值 10

`0` 是 falsy 值,使用 `||` 会导致预期为「不限制」的 `0` 被设置为默认值 `10`
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @MoYingJi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在解决音乐缓存服务中一个关键的逻辑问题,即当用户将缓存大小上限设置为 0 以表示不限制时,由于使用了 || 操作符,该 0 值会被错误地解释为需要应用默认值 10。通过将 || 替换为 ??,确保了 0 能够被正确识别为有效配置,从而使“不限制”的意图得以正确实现,提升了缓存配置的准确性和灵活性。

Highlights

  • 缓存逻辑修复: 修复了音乐缓存大小上限的默认值处理逻辑,确保当用户明确设置缓存上限为0时,该值能被正确识别为“不限制”。
  • 操作符变更: 将 electron/main/services/MusicCacheService.ts 文件中的 || (逻辑或) 操作符替换为 ?? (空值合并) 操作符,以避免 0 被误判为假值。
  • 零值处理: 此更改确保了 store.get("cacheLimit") 返回 0 时,limitSizeGB 变量将正确地赋值为 0,而不是回退到默认值 10
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次变更修复了缓存大小上限处理的一个逻辑问题。之前使用 || 操作符会导致用户设置的 0(代表不限制)被错误地覆盖为默认值 10。通过改用空值合并操作符 ??,确保了 0 作为一个有效的设置值被正确处理,只有在值为 nullundefined 时才会使用默认值。这是一个精准且重要的修复,提升了配置的可靠性。

@imsyy imsyy merged commit 88db937 into SPlayer-Dev:dev Dec 21, 2025
@MoYingJi MoYingJi deleted the fix branch December 21, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants