Skip to content

style(MainAMLyric): 优化歌词滚动位置靠近顶部时的样式#668

Merged
imsyy merged 1 commit into
SPlayer-Dev:devfrom
MoYingJi:pr/a
Dec 27, 2025
Merged

style(MainAMLyric): 优化歌词滚动位置靠近顶部时的样式#668
imsyy merged 1 commit into
SPlayer-Dev:devfrom
MoYingJi:pr/a

Conversation

@MoYingJi
Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @MoYingJi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在优化歌词组件的显示样式,特别是当歌词配置为在播放器顶部附近滚动时。它调整了活动歌词行的垂直定位,并引入了一个明确的对齐锚点,以改善视觉体验并确保顶部对齐歌词的一致行为。

Highlights

  • 优化歌词滚动位置: 当歌词滚动位置不居中时,将当前播放歌词的对齐位置从0.2调整到0.15,使其更靠近顶部显示。
  • 新增对齐锚点属性: 引入了一个新的alignAnchor属性,用于明确指定歌词滚动的对齐锚点。当歌词滚动位置居中时,锚点为'center';否则为'top'。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 优化了歌词滚动到顶部时的样式,通过调整 alignPosition 和新增 alignAnchor 属性,使得歌词在靠近顶部时显示效果更好。

代码改动很直接,主要是对 LyricPlayer 组件的属性进行了微调。我有一个关于代码可读性和减少重复代码的建议,请查看具体的审查评论。总体来说,这是一个不错的优化。

Comment on lines +20 to +21
:alignPosition="settingStore.lyricsScrollPosition === 'center' ? 0.5 : 0.15"
:alignAnchor="settingStore.lyricsScrollPosition === 'center' ? 'center' : 'top'"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

为了提高代码的可读性和可维护性,可以考虑将重复的条件 settingStore.lyricsScrollPosition === 'center' 提取到一个计算属性中。

例如,在 <script setup> 部分添加:

const isCenterAligned = computed(() => settingStore.lyricsScrollPosition === 'center');

然后在模板中可以这样使用:

:alignPosition="isCenterAligned ? 0.5 : 0.15"
:alignAnchor="isCenterAligned ? 'center' : 'top'"

这样做可以避免在模板中重复逻辑,使代码更清晰,也便于未来可能的扩展。

@imsyy imsyy merged commit 2616de6 into SPlayer-Dev:dev Dec 27, 2025
@MoYingJi MoYingJi deleted the pr/a branch December 27, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants