Skip to content

style(am-lyric): 修复 pureLyricMode 下 AMLL 的样式#743

Merged
imsyy merged 1 commit into
SPlayer-Dev:devfrom
MoYingJi:pr/as
Jan 14, 2026
Merged

style(am-lyric): 修复 pureLyricMode 下 AMLL 的样式#743
imsyy merged 1 commit into
SPlayer-Dev:devfrom
MoYingJi:pr/as

Conversation

@MoYingJi
Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @MoYingJi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在解决纯净歌词显示模式(pureLyricMode)下的样式不一致问题。此前,对唱歌词在纯净模式下可能会被错误地居中显示,影响用户体验。通过引入检测对唱行的机制并有条件地应用居中样式,此PR确保了对唱歌词的正确显示,同时保持了常规歌词在纯净模式下的居中布局。此外,还进行了一项小的优化,通过忽略空行来改进歌词语言处理。

Highlights

  • 对唱歌词样式调整: 引入了 hasDuet 响应式属性来检测当前歌词是否包含对唱行,并根据此属性为歌词容器动态添加 duet CSS 类。
  • 纯净模式居中逻辑优化: 调整了 pureLyricMode 下的样式,确保歌词居中(text-align: centertransform-origin: center)仅在没有对唱行时应用,从而避免对唱歌词在纯净模式下被错误居中。
  • 歌词语言处理改进: 在处理歌词语言时,增加了跳过空歌词行的逻辑,提高了处理效率和准确性。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 修复了 pureLyricMode 下 AMLL 歌词的样式问题,主要是通过引入 hasDuet 状态来区分对唱和非对唱歌词的居中显示。代码改动方向正确,我主要提出了一些关于代码风格和 Vue 最佳实践的建议,以提高代码的可读性和可维护性。例如,简化了 class 绑定语法,指出了在 computed property 中产生副作用的问题并建议使用 watch 替代,以及修正了一处 CSS 缩进错误。

Comment thread src/components/Player/MainAMLyric.vue Outdated
Comment thread src/components/Player/MainAMLyric.vue Outdated
Comment thread src/components/Player/MainAMLyric.vue Outdated
@MoYingJi MoYingJi force-pushed the pr/as branch 3 times, most recently from 81c0a7e to 6c9906a Compare January 13, 2026 11:17
@imsyy imsyy merged commit 0252bc0 into SPlayer-Dev:dev Jan 14, 2026
@MoYingJi MoYingJi deleted the pr/as branch January 14, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants