Skip to content

🐞 fix: 修复日志洪水的问题#752

Merged
imsyy merged 2 commits into
SPlayer-Dev:devfrom
apoint123:fix/log-flodding
Jan 21, 2026
Merged

🐞 fix: 修复日志洪水的问题#752
imsyy merged 2 commits into
SPlayer-Dev:devfrom
apoint123:fix/log-flodding

Conversation

@apoint123
Copy link
Copy Markdown
Member

通过添加日志过滤器来避免打印大量其他crate的日志

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @apoint123, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求通过实现更精细的日志过滤来解决日志洪水问题。它配置 tracing 订阅者,使其专门针对源自 external_media_integration crate 的日志,从而抑制来自其他模块的过多日志记录。此更改通过阻止处理和存储不相关的日志消息,提高了日志的可读性并减少了资源消耗。

Highlights

  • 引入日志目标过滤器: 为文件和标准输出日志层引入了 tracing_subscriber::filter::Targets,以精确控制日志输出。
  • 限制日志输出范围: 日志现在仅针对 external_media_integration crate 进行过滤,文件日志级别为 TRACE,标准输出日志级别为 WARN,从而避免了其他 crate 的日志洪水。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 通过为日志记录器添加 Targets 过滤器,成功解决了日志泛滥的问题。现在只有本 crate (external_media_integration) 产生的日志会被记录,有效避免了来自其他依赖库的大量无关日志。代码实现正确,达到了预期目的。我只提一个关于代码可维护性的建议:使用 env!("CARGO_PKG_NAME") 宏来动态获取 crate 名称,而不是硬编码,这样可以避免在未来重命名包时需要手动修改此处的代码。

Comment thread native/external-media-integration/src/logger.rs Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@apoint123
Copy link
Copy Markdown
Member Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

这个 PR 通过为日志记录器添加目标过滤器,有效地解决了日志泛滥的问题。这是一个很好的改进。我提出了一个建议,通过使用 EnvFilter 来进一步提高日志配置的灵活性。这将允许在需要调试时,通过环境变量轻松地启用来自其他 crate 的日志,而不会影响默认的简洁日志输出。这会让未来的调试工作更加方便。

Comment thread native/external-media-integration/src/logger.rs
@imsyy imsyy merged commit b400b2b into SPlayer-Dev:dev Jan 21, 2026
@apoint123 apoint123 deleted the fix/log-flodding branch February 8, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants