Skip to content

feat: 避免含有标题的较短本地音乐因时长或文件大小而被排除#796

Merged
imsyy merged 3 commits into
SPlayer-Dev:devfrom
kyv001:feature/not-skip-short-music
Feb 1, 2026
Merged

feat: 避免含有标题的较短本地音乐因时长或文件大小而被排除#796
imsyy merged 3 commits into
SPlayer-Dev:devfrom
kyv001:feature/not-skip-short-music

Conversation

@kyv001
Copy link
Copy Markdown
Contributor

@kyv001 kyv001 commented Feb 1, 2026

在一些专辑中(如Exhale EP - Devin Wild)会有作为过渡的短小间奏曲目。这些曲目的本地文件往往时长小于30秒或者文件大小小于1MB从而会被本地曲目扫描器排除。但这些曲目作为专辑的一部分不应被排除。

解决方案:仅当确认本地文件没有标题时将过短或过小的音频文件过滤,避免误伤短小曲目。

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @kyv001, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在改进本地音乐扫描器的行为,以更智能地处理短小或文件大小较小的音乐文件。通过修改过滤逻辑,它现在能够识别并包含那些作为专辑一部分但可能因其时长或大小而被错误排除的合法曲目,特别是那些带有标题的间奏曲。

Highlights

  • 优化本地音乐扫描逻辑: 移除了对小于1MB文件的无条件排除,并调整了时长和文件大小的过滤规则。
  • 避免误伤短小曲目: 现在,只有当本地音乐文件没有标题元数据时,才会应用时长(小于30秒或大于2小时)和文件大小(小于1MB)的过滤规则。
  • 提升用户体验: 确保专辑中的短小间奏曲目(如EP中的过渡曲)能够被正确扫描和显示,即使它们时长很短或文件很小。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

你好,感谢你的贡献。这个 PR 的改动很棒,它通过仅在音轨无标题时进行时长和大小过滤,巧妙地解决了短小曲目(如专辑中的间奏曲)被错误排除的问题。

代码实现逻辑清晰,我只有一些关于代码可读性和可维护性的建议:

  1. 可以将两个关于时长的 if 判断合并,使代码更简洁。
  2. 建议将过滤条件中的魔法数字(如 30, 7200)提取为具名常量,以提高代码的可读性和可维护性。

具体的修改建议请见我的行间评论。总体来说,这是一个很好的改进!

Comment on lines +232 to +235
// 时长 < 30s
if (metadata.format.duration && metadata.format.duration < 30) return;
// 时长 > 2h (7200s)
if (metadata.format.duration && metadata.format.duration > 7200) return;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

为了使代码更简洁,可以将两个关于时长的 if 判断合并为一个。这样可以减少代码行数,并使过滤逻辑更紧凑。

Suggested change
// 时长 < 30s
if (metadata.format.duration && metadata.format.duration < 30) return;
// 时长 > 2h (7200s)
if (metadata.format.duration && metadata.format.duration > 7200) return;
// 时长 < 30s 或 > 2h (7200s)
if (metadata.format.duration && (metadata.format.duration < 30 || metadata.format.duration > 7200)) return;

Comment thread electron/main/services/LocalMusicService.ts
@imsyy imsyy merged commit 4cdd3d8 into SPlayer-Dev:dev Feb 1, 2026
@kyv001 kyv001 deleted the feature/not-skip-short-music branch February 8, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants