feat(上下文菜单): 新增复制歌曲名称和音乐标签编辑选项 在设置菜单中增加两个新的上下文菜单选项:复制歌曲名称和音乐标签编辑。同时调整了菜单项的分隔符显示逻辑,并将"从歌单中删除"选项移动到更合适的位置。#826
Conversation
当歌词原本就是TTML格式且未与其他歌词合并时,避免重新生成TTML内容,以防止原始内容丢失。同时优化文件扩展名判断逻辑,确保转换后的YRC歌词也能正确保存为TTML格式。
在设置菜单中增加两个新的上下文菜单选项:复制歌曲名称和音乐标签编辑。同时调整了菜单项的分隔符显示逻辑,并将"从歌单中删除"选项移动到更合适的位置。
将侧边栏歌单模式的状态管理从组件本地状态迁移至 Pinia 设置存储中,以支持跨组件状态持久化与同步。
This reverts commit af30825.
Summary of ChangesHello @kazukokawagawa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求主要通过引入新的上下文菜单功能来增强用户交互性,允许用户直接复制歌曲名称和编辑音乐标签,并使这些功能可配置。此外,它还改进了现有菜单项的组织结构和显示逻辑,并对歌词文件下载和保存的后端处理进行了精细化调整,以提高其准确性和鲁棒性。 Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| key: "line-2", | ||
| type: "divider", | ||
| show: isLocal, | ||
| show: | ||
| isLocal && |
There was a problem hiding this comment.
此分隔符(line-2)的显示逻辑似乎不太正确。它的可见性不应该依赖于 copyName 选项,因为 copyName 与该分隔符所要分隔的“音乐标签编辑”功能在逻辑上并无直接关联。
当用户在设置中禁用了“复制歌曲名称”但启用了“音乐标签编辑”时,此分隔符将不会显示,导致“音乐标签编辑”选项前缺少了预期的分隔,破坏了菜单项的分组视觉效果。
建议将此处的 show 条件修改为与 meta-edit 项的显示条件保持一致,即仅当“音乐标签编辑”选项本身可见时才显示此分隔符。
show: settingStore.contextMenuOptions.musicTagEditor && isLocal,移除对复制名称选项的依赖,仅根据音乐标签编辑器选项和是否为本地歌曲决定是否显示分隔符,以更准确地反映功能可用性。
No description provided.