feat(taskbar): 添加任务栏逐字歌词功能#918
Conversation
laoshuikaixue
commented
Feb 21, 2026
- 在 TaskbarLyric 组件中添加 words 和 currentTime 属性传递
- 引入 LyricWord 类型定义并扩展 lyric line 数据结构
- 实现逐字歌词渲染逻辑和进度计算功能
- 添加任务栏设置中的逐字歌词开关选项
- 集成 IPC 通信以支持逐字歌词配置传递
- 实现基于时间轴的逐字进度动画效果
- 添加 CSS 样式实现逐字歌词遮罩渐变效果
- 在 TaskbarLyric 组件中添加 words 和 currentTime 属性传递 - 引入 LyricWord 类型定义并扩展 lyric line 数据结构 - 实现逐字歌词渲染逻辑和进度计算功能 - 添加任务栏设置中的逐字歌词开关选项 - 集成 IPC 通信以支持逐字歌词配置传递 - 实现基于时间轴的逐字进度动画效果 - 添加 CSS 样式实现逐字歌词遮罩渐变效果
Summary of ChangesHello @laoshuikaixue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求为任务栏歌词功能引入了逐字歌词显示。它通过在设置中添加一个新选项来启用此功能,更新了任务栏配置以包含此设置,并实现了逐字歌词的渲染逻辑,包括基于时间轴的进度动画和视觉渐变效果。这些更改还涉及扩展数据类型和IPC通信,以确保逐字歌词功能在整个应用程序中正确传递和应用。 Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR effectively implements the taskbar word-by-word lyric feature. The code structure is clear, and the integration of new features is well-considered, such as adding rendering logic for word-by-word lyrics in the TaskbarLyric component and utilizing CSS mask-image for a karaoke effect; adding a switch for word-by-word lyrics in the settings, and ensuring configuration is passed from the main process to the render process; and updating relevant data types and interfaces to support word-by-word lyric data. The overall code quality is high. I only found one issue: a watch in useInit.ts is missing a dependency, which may cause the taskbar lyric style not to update when the theme is switched. I have provided specific modification suggestions for this.
2026-02-21.19-33-18.mp4 |
- 添加 themeMode 到 watch 依赖数组中 - 确保主题模式改变时触发相应更新
- 将 showYrc 配置项重命名为 showWordLyrics - 统一歌词相关设置的命名规范 - 调整歌词渲染逻辑以适配新的配置项名称 - 统一任务栏歌词遮罩透明度