Skip to content

fix(lyricParser): 修复 WordByWord 格式 LRC 解析错误#994

Merged
imsyy merged 1 commit into
SPlayer-Dev:devfrom
MoYingJi:pr/fix
Mar 13, 2026
Merged

fix(lyricParser): 修复 WordByWord 格式 LRC 解析错误#994
imsyy merged 1 commit into
SPlayer-Dev:devfrom
MoYingJi:pr/fix

Conversation

@MoYingJi
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings March 13, 2026 16:20
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在解决 WordByWord 格式 LRC 歌词解析中的一个现有问题。通过精确调整用于提取逐字歌词文本段的正则表达式,确保了 LRC 文件的正确解释和处理。

Highlights

  • LRC 解析错误修复: 修复了 WordByWord 格式 LRC 歌词解析中的一个错误。
  • 正则表达式更新: 更新了 WORD_BY_WORD_PATTERN 正则表达式,以正确匹配歌词文本内容。
Changelog
  • src/utils/lyric/lyricParser.ts
    • 修正了用于解析 WordByWord LRC 行的正则表达式。
Activity
  • 此拉取请求尚未记录任何人工活动。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@imsyy imsyy merged commit 9f61526 into SPlayer-Dev:dev Mar 13, 2026
2 checks passed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次 PR 修复了 parseWordByWordLrc 函数中用于解析逐字歌词的正则表达式。修改后的正则表达式将 [] 字符都排除在歌词内容之外,解决了先前版本中可能出现的解析错误。此更改符合预期,我没有发现其他问题。

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

该 PR 修复逐字(WordByWord)LRC 的解析错误,使歌词内容在按时间标签切分时能正确捕获完整词片段,从而提升逐字歌词的解析准确性。

Changes:

  • 修正 parseWordByWordLrc 中用于匹配逐字片段的正则表达式,避免词内容被错误截断/匹配异常。

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants