feat(MusicWiki): 在音乐百科页面上显示操作菜单#999
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求通过在音乐百科页面上集成歌曲操作菜单来增强用户体验。该菜单使用户能够快速访问与当前歌曲相关的操作，例如从播放列表或本地存储中删除歌曲。底层的菜单逻辑已进行重构，以支持可选的事件发射，使菜单可组合函数更适应不同的UI上下文，包括某些操作可能不直接适用的只读视图。 Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| // 删除本地歌曲 | ||
| const deleteLocalSong = (song: SongType, emit: (event: "removeSong", args: any[]) => void) => { | ||
| const deleteLocalSong = (song: SongType, emit?: (event: "removeSong", args: any[]) => void) => { | ||
| if (emit === undefined) return; |
There was a problem hiding this comment.
在 deleteLocalSong 函数中，当 emit 未定义时直接返回，会阻止在没有 emit 的上下文（如音乐百科页面）中执行删除本地文件的核心逻辑。为了让功能更通用，建议移除此行，并在 onPositiveClick 回调中改用可选链调用 emit (即 emit?.("removeSong", [song.id]))。
这样即使用户从音乐百科页面操作，也能成功删除本地文件。当然，这还需要配合修改菜单项的 show 条件。
There was a problem hiding this comment.
从歌单中删除需要歌单，你在音乐百科里怎么知道你是要删哪个歌单
| show: settingStore.contextMenuOptions.deleteFromLocal && isLocal && !isCurrent, | ||
| show: | ||
| settingStore.contextMenuOptions.deleteFromLocal && | ||
| emit !== undefined && |
There was a problem hiding this comment.
为了能在音乐百科等没有 emit 函数的页面上显示“从本地磁盘中删除”选项，应移除对 emit 的检查。此更改应与对 deleteLocalSong 函数的建议修改一并进行。
There was a problem hiding this comment.
Pull request overview
该 PR 为“音乐百科（Song Wiki）”页面补齐歌曲操作入口，使用户在百科页也能直接执行常见歌曲操作（播放、更多操作菜单）。
Changes:
Song/wiki.vue：在百科页头部新增“更多”下拉菜单按钮，并接入useSongMenu().getMenuOptions生成菜单项useSongMenu.ts：调整菜单生成与部分删除逻辑的参数为可选/提供默认值，以支持在非列表上下文（无 index / 无 emit）调用
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/views/Song/wiki.vue | 在百科页头部增加下拉操作菜单入口，并调整 actions 区域布局/样式以容纳更多按钮 |
| src/composables/useSongMenu.ts | 允许在缺少列表上下文参数时生成菜单；对依赖 emit 的删除类操作增加约束 |
You can also share your feedback on Copilot code review. Take the survey.
| const getMenuOptions = ( | ||
| song: SongType, | ||
| index: number, | ||
| index: number = -1, | ||
| playListId: number = 0, | ||
| isDailyRecommend: boolean = false, | ||
| emit: (event: "removeSong", args: any[]) => void, | ||
| emit?: (event: "removeSong", args: any[]) => void, | ||
| ): DropdownOption[] => { |
No description provided.