Feat: Enable anonymized analytics for the SQLMesh core#2602
Merged
izeigerman merged 4 commits intomainfrom May 15, 2024
Merged
Conversation
Add docs
2d57a1e to
bb55000
Compare
tobymao
reviewed
May 13, 2024
tobymao
reviewed
May 13, 2024
| atexit.register(collector.shutdown, flush=True) | ||
|
|
||
|
|
||
| def disable_analytics() -> None: |
Contributor
There was a problem hiding this comment.
why did you choose to do this pattern? should collector instead be a constant like COLLECTOR, which can then be disabled?
Contributor
Author
There was a problem hiding this comment.
This allowed me to reuse existing constructs (eg dispatcher) without explicitly adding disable API to the collector. I don't feel strongly about either approach. Do you see any advantages to doing this the way you suggested?
tobymao
reviewed
May 13, 2024
tobymao
reviewed
May 13, 2024
tobymao
reviewed
May 13, 2024
tobymao
reviewed
May 13, 2024
tobymao
reviewed
May 13, 2024
tobymao
reviewed
May 13, 2024
tobymao
reviewed
May 13, 2024
tobymao
reviewed
May 13, 2024
tobymao
reviewed
May 13, 2024
tobymao
reviewed
May 13, 2024
tobymao
reviewed
May 14, 2024
tobymao
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We prioritize our development work based on the needs of SQLMesh users. Some users share their needs via our Slack or Github communities, but many do not. We have added some simple anonymized usage information (telemetry) to SQLMesh to ensure the needs of all users are heard.
All information is anonymized with hash functions, so we could not link data to a specific company, user, or project even if we wanted to (which we don't!). No information is related to credentials or authentication.
We collect anonymized information about SQLMesh project complexity and usage - for example, number of models, count of model kinds, project load time, whether an error occurred during a plan/run (no stacktraces or error message), and names (but not values) of the arguments passed to CLI commands.
The collection of anonymized usage information can be disabled with these methods:
disable_anonymized_analytics: truekey in the SQLMesh project configuration fileSQLMESH__DISABLE_ANONYMIZED_ANALYTICSset to1,true,t,yes, ory