Fix: set columns attribute for python models that generate sql#3087
Merged
izeigerman merged 3 commits intoSQLMesh:mainfrom Sep 4, 2024
Merged
Conversation
|
|
georgesittas
approved these changes
Sep 4, 2024
Contributor
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
LGTM - thanks for fixing this!
georgesittas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We encountered this while making a python model that had
is_sql=True. We send some generative things to our clickhouse instance and because we use the clickhouse dialect this seems to cause some issues when attempting to transpile to other dialects likeduckdbdue to theNullabletype appearing as a derived type for a specific column of the final result. So to solve this we decided to just explicitly set the columns in the python sql model. However we encountered a bug in doing this.