From 5010666a9255c191d7bff0899957a4bb2e9bc916 Mon Sep 17 00:00:00 2001 From: Leandro Ostera Date: Tue, 7 May 2019 08:09:51 +0200 Subject: [PATCH 1/3] Fix #3 by putting link in a comment --- config.yml | 5 +++ responses/01.00-setup.activities.md | 57 ++++++++++++++++++++++++++++ responses/01.00-setup.md | 59 ----------------------------- 3 files changed, 62 insertions(+), 59 deletions(-) create mode 100644 responses/01.00-setup.activities.md diff --git a/config.yml b/config.yml index 493c077..8415315 100644 --- a/config.yml +++ b/config.yml @@ -37,6 +37,11 @@ steps: body: 01.00-setup.md head: setup action_id: setup_pr + - type: respond + issue: '%actions.setup_pr.data.number%' + with: 01.00-setup.activities.md + data: + repo_ssh_url: '%actions.setup_pr.data.ssh_url%' - type: assignRegistrant issue: '%actions.setup_pr.data.number%' - type: respond diff --git a/responses/01.00-setup.activities.md b/responses/01.00-setup.activities.md new file mode 100644 index 0000000..4ba1689 --- /dev/null +++ b/responses/01.00-setup.activities.md @@ -0,0 +1,57 @@ +## โŒจ๏ธ Activities! + +### Step 0.0 โ€” Install Node ๐Ÿš€ + +If you don't have `node` installed, you can normally get it here: https://nodejs.org/en/ + +But you may also be able to get it through your package manager of choice: + +* on Debian-based Linuxes systems that would look like `apt-get install node`, +* on macOS with Homebrew it would look like `brew install node`, +* on Windows with Choco it looks like `choco install nodejs.install` + +But either way, you can just go to the website above, download the installer, and get it set up in a few clicks. + +### Step 0.1 โ€” Install Yarn ๐Ÿงถ + +Since this course makes some assumptions on the `yarn` tool, we will need to install it. + +You can run `npm install --global yarn` to get the latest version of `yarn` globally available, and you +can verify that you have `yarn` installed by running `yarn --version`. + +### Step 1.0 โ€” Clone the Project ๐Ÿ“ฆ + +1. Clone this repo to your computer + + ``` + git clone {{ repo_url }} + ``` + + > If you haven't done this before, we recommend @github's guide on [Cloning Repositories](https://help.github.com/en/articles/cloning-a-repository). It is super short and will get you started. + +2. Go to the project folder in your computer and check out the `setup` branch. + + ``` + cd reason-todo-app + git checkout setup + ``` + +2. Run `yarn` to install all necessary dependencies: + + ``` + yarn + ``` + + > NOTE: installing dependencies sometimes can take a while and sometimes can fail because the internet is not perfect. If you have any trouble, please try again. If it still doesn't work, tweet at us [@SRC_technology](https://twitter.com/SRC_technology) and we'll try to help! ๐Ÿ™ + +3. After the installation is completed, you will have 1 new file (`yarn.lock`) and 1 new folder (`node_modules`). Make sure to add the `yarn.lock` file with `git`, commit it, and push your changes. You can do that by running: + + ```sh + git add yarn.lock + git commit --message "Add yarn.lock" + git push origin setup + ``` + +---- + +I will post more steps once these are completed ๐Ÿค“ โ€” if you need any help, you can always find me on Twitter: [@SRC_technology](https://twitter.com/SRC_technology) diff --git a/responses/01.00-setup.md b/responses/01.00-setup.md index 4f4d320..db0a484 100644 --- a/responses/01.00-setup.md +++ b/responses/01.00-setup.md @@ -5,62 +5,3 @@ And so it begins! ๐Ÿง™๐Ÿผโ€โ™‚๏ธ This Learning Lab has a single prerrequisite If you have never used [Node.js](https://nodejs.org/en/) before, don't worry, we'll include all the necessary steps for you to take, and guide you along the way. Now let's cover those prerrequisites, shall we? - -## โŒจ๏ธ Activities! - -### Step 0.0 โ€” Install Node ๐Ÿš€ - -If you don't have `node` installed, you can normally get it here: https://nodejs.org/en/ - -But you may also be able to get it through your package manager of choice: - -* on Debian-based Linuxes systems that would look like `apt-get install node`, -* on macOS with Homebrew it would look like `brew install node`, -* on Windows with Choco it looks like `choco install nodejs.install` - -But either way, you can just go to the website above, download the installer, and get it set up in a few clicks. - -### Step 0.1 โ€” Install Yarn ๐Ÿงถ - -Since this course makes some assumptions on the `yarn` tool, we will need to install it. - -You can run `npm install --global yarn` to get the latest version of `yarn` globally available, and you -can verify that you have `yarn` installed by running `yarn --version`. - -### Step 1.0 โ€” Clone the Project ๐Ÿ“ฆ - -1. Clone this repo to your computer - - ``` - git clone git@github.com:{{ user.username }}/reason-todo-app - ``` - - > If you haven't done this before, we recommend @github's guide on [Cloning Repositories](https://help.github.com/en/articles/cloning-a-repository). It is super short and will get you started. - -2. Go to the project folder in your computer and check out the `setup` branch. - - ``` - cd reason-todo-app - git checkout setup - ``` - -2. Run `yarn` to install all necessary dependencies: - - ``` - yarn - ``` - -> NOTE: installing dependencies sometimes can take a while and sometimes can fail because the internet is not perfect. -> If you have any trouble, please try again. If it still doesn't work, tweet at us [@SRC_technology](https://twitter.com/SRC_technology) and we'll try to help! ๐Ÿ™ - -3. After the installation is completed, you will have 1 new file (`yarn.lock`) and 1 new folder (`node_modules`). Make sure to add the `yarn.lock` file with `git`, commit it, and push your changes. You can do that by running: - -```sh -git add yarn.lock -git commit --message "Add yarn.lock" -git push origin setup -``` - ----- - -I will post more steps once these are completed ๐Ÿค“ โ€” if you need any help, you can always find me on Twitter: [@SRC_technology](https://twitter.com/SRC_technology) From 37c5abf1595face5e38a3e0bb5fd65f82cf47b49 Mon Sep 17 00:00:00 2001 From: Leandro Ostera Date: Tue, 7 May 2019 08:13:14 +0200 Subject: [PATCH 2/3] Fix last link being broken (issue #4) --- config.yml | 11 ++++++----- responses/01.06-github-pages.md | 2 +- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/config.yml b/config.yml index 8415315..1cdba47 100644 --- a/config.yml +++ b/config.yml @@ -118,22 +118,23 @@ steps: left: '%payload.review.state%' operator: === right: approved + - type: createIssue + title: This is just the Beginning! + body: 02.00-end.md + action_id: final_issue - type: respond with: 01.06-github-pages.md data: - next_pr: '%actions.app_pr.data.html_url%' + final_issue: '%actions.final_issue.data.html_url%' - type: mergePullRequest pullRequest: Getting Started - type: deleteBranch branch: setup - - type: createIssue - title: This is just the Beginning! - body: 02.00-end.md - title: 'Fin: Wrapping it up!' description: Additional links event: issues - link: '{{ repoUrl }}/issues/3' + link: '%actions.final_issue.data.html_url%' actions: - type: gate left: '%payload.action%' diff --git a/responses/01.06-github-pages.md b/responses/01.06-github-pages.md index 9d4248f..1b74125 100644 --- a/responses/01.06-github-pages.md +++ b/responses/01.06-github-pages.md @@ -6,4 +6,4 @@ This repository is set up so that when you enable Github Pages you can share the Now I'm going to merge this PR and delete this branch. You are good to go. -But before we go, [one final issue]({{repo}}/issue/3). +But before we go, [one final issue]({{final_issue_url}}). From a9daa62d6ef197dabff3e74dda32aa417015721d Mon Sep 17 00:00:00 2001 From: Leandro Ostera Date: Tue, 7 May 2019 08:15:17 +0200 Subject: [PATCH 3/3] Drop prefix for steps title --- config.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/config.yml b/config.yml index 1cdba47..3f2b694 100644 --- a/config.yml +++ b/config.yml @@ -49,7 +49,7 @@ steps: data: url: '%actions.setup_pr.data.html_url%' -- title: 'Local Setup: Install Dependencies' +- title: 'Install Dependencies' description: Get the repo up and working in your computer event: pull_request.synchronize link: '%actions.setup_pr.data.html_url%' @@ -64,7 +64,7 @@ steps: - type: respond with: 01.01-install-vs-code.md -- title: 'Local Setup: VS Code' +- title: 'Setting up an Editor' description: Install VS Code event: pull_request.synchronize link: '%actions.setup_pr.data.html_url%' @@ -79,7 +79,7 @@ steps: - type: respond with: 01.02-build-project.md -- title: 'Local Setup: Build Project' +- title: 'Building the Project' description: Create project bundle event: pull_request.synchronize link: '%actions.setup_pr.data.html_url%' @@ -94,7 +94,7 @@ steps: - type: respond with: 01.03-run-tests.md -- title: 'Local Setup: Test Project' +- title: 'Testing the Project' description: Run the tests in the project. event: pull_request.synchronize link: '%actions.setup_pr.data.html_url%' @@ -109,7 +109,7 @@ steps: - type: respond with: 01.05-check-app-local.md -- title: 'Local Setup: Check App Works' +- title: 'Verifying the App Works' description: Create project bundle event: pull_request_review.submitted link: '%actions.setup_pr.data.html_url%'