Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Add "enabled" option to domain section #4743

Closed
sssd-bot opened this issue May 2, 2020 · 2 comments
Closed

[RFE] Add "enabled" option to domain section #4743

sssd-bot opened this issue May 2, 2020 · 2 comments
Assignees
Labels

Comments

@sssd-bot
Copy link

sssd-bot commented May 2, 2020

Cloned from Pagure issue: https://pagure.io/SSSD/sssd/issue/3735


Instead of enabling domains using the "domains" option in [sssd] section we could have [domain/*] option "enabled". This would allow admins to configure and enable domain in the same snippet file.

Comments


Comment from jhrozek at 2018-05-23 17:18:50

Metadata Update from @jhrozek:

  • Issue set to the milestone: SSSD 1.16.2

Comment from jhrozek at 2018-05-23 17:20:27

Metadata Update from @jhrozek:

  • Issue set to the milestone: SSSD Future releases (no date set yet) (was: SSSD 1.16.2)

Comment from thalman at 2020-03-11 14:47:05

Metadata Update from @thalman:

  • Issue tagged with: Future milestone, easyfix

Comment from thalman at 2020-03-11 14:48:53

Metadata Update from @thalman:

  • Issue untagged with: Future milestone, easyfix
  • Issue tagged with: Next milestone

Comment from pbrezina at 2020-03-11 14:49:48

Metadata Update from @pbrezina:

  • Issue tagged with: New hire task
@avisiedo avisiedo self-assigned this May 20, 2020
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 1, 2020
Append the unit tests for the feature.

Resolves:
SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 16, 2020
Append the unit tests for the feature.

Resolves:
SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 17, 2020
Append the unit tests for the feature.

Resolves:
SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 18, 2020
Append the unit tests for the feature.

Resolves:
SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 19, 2020
Append the unit tests for the feature.

Resolves:
SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 19, 2020
Append the unit tests for the feature.

Resolves:
SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 23, 2020
Append the unit tests for the feature.

Resolves:
SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 23, 2020
A new attribute is appended to [domain/*] sections so that
a domain ca be enabled/disabled by domain section and for
extension by configuration file if each domain is divided
in separate files.

This attribute override the list of domains at [sssd]
section, however the new **enabled** attribute override
the values of the list. If no **enabled** attribute is
found for a domain section, the domain list criteria is
used to enable/disable a domain.

Resolves:
SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 23, 2020
A new attribute is appended to [domain/*] sections so that
a domain ca be enabled/disabled by domain section and for
extension by configuration file if each domain is divided
in separate files.

This attribute override the list of domains at [sssd]
section, however the new **enabled** attribute override
the values of the list. If no **enabled** attribute is
found for a domain section, the domain list criteria is
used to enable/disable a domain.

Resolves:
SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 24, 2020
A new attribute is appended to [domain/*] sections so that
a domain ca be enabled/disabled by domain section and for
extension by configuration file if each domain is divided
in separate files.

This attribute override the list of domains at [sssd]
section, however the new **enabled** attribute override
the values of the list. If no **enabled** attribute is
found for a domain section, the domain list criteria is
used to enable/disable a domain.

Resolves:
SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 25, 2020
A new attribute is appended to [domain/*] sections so that
a domain ca be enabled/disabled by domain section and for
extension by configuration file if each domain is divided
in separate files.

This attribute override the list of domains at [sssd]
section, however the new **enabled** attribute override
the values of the list. If no **enabled** attribute is
found for a domain section, the domain list criteria is
used to enable/disable a domain.

Resolves: SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 28, 2020
A new attribute is appended to [domain/*] sections so that
a domain ca be enabled/disabled by domain section and for
extension by configuration file if each domain is divided
in separate files.

This attribute override the list of domains at [sssd]
section, however the new **enabled** attribute override
the values of the list. If no **enabled** attribute is
found for a domain section, the domain list criteria is
used to enable/disable a domain.

Resolves: SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 29, 2020
A new attribute is appended to [domain/*] sections so that
a domain ca be enabled/disabled by domain section and for
extension by configuration file if each domain is divided
in separate files.

This attribute override the list of domains at [sssd]
section, however the new **enabled** attribute override
the values of the list. If no **enabled** attribute is
found for a domain section, the domain list criteria is
used to enable/disable a domain.

Resolves: SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jun 29, 2020
A new attribute is appended to [domain/*] sections so that
a domain ca be enabled/disabled by domain section and for
extension by configuration file if each domain is divided
in separate files.

This attribute override the list of domains at [sssd]
section, however the new **enabled** attribute override
the values of the list. If no **enabled** attribute is
found for a domain section, the domain list criteria is
used to enable/disable a domain.

Resolves: SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jul 7, 2020
A new attribute is appended to [domain/*] sections so that
a domain ca be enabled/disabled by domain section and for
extension by configuration file if each domain is divided
in separate files.

This attribute override the list of domains at [sssd]
section, however the new **enabled** attribute override
the values of the list. If no **enabled** attribute is
found for a domain section, the domain list criteria is
used to enable/disable a domain.

Resolves: SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jul 7, 2020
A new attribute is appended to [domain/*] sections so that
a domain ca be enabled/disabled by domain section and for
extension by configuration file if each domain is divided
in separate files.

This attribute override the list of domains at [sssd]
section, however the new **enabled** attribute override
the values of the list. If no **enabled** attribute is
found for a domain section, the domain list criteria is
used to enable/disable a domain.

Resolves: SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jul 8, 2020
A new attribute is appended to [domain/*] sections so that
a domain ca be enabled/disabled by domain section and for
extension by configuration file if each domain is divided
in separate files.

This attribute override the list of domains at [sssd]
section, however the new **enabled** attribute override
the values of the list. If no **enabled** attribute is
found for a domain section, the domain list criteria is
used to enable/disable a domain.

Resolves: SSSD#4743
avisiedo added a commit to avisiedo/sssd that referenced this issue Jul 9, 2020
A new attribute is appended to [domain/*] sections so that
a domain ca be enabled/disabled by domain section and for
extension by configuration file if each domain is divided
in separate files.

This attribute override the list of domains at [sssd]
section, however the new **enabled** attribute override
the values of the list. If no **enabled** attribute is
found for a domain section, the domain list criteria is
used to enable/disable a domain.

Resolves: SSSD#4743
@pbrezina
Copy link
Member

Pushed PR: #5213

  • master
    • ff8d7b8 - config: [RFE] Add "enabled" option to domain section

@pbrezina pbrezina added the Closed: Fixed Issue was closed as fixed. label Jul 14, 2020
alexey-tikhonov added a commit to alexey-tikhonov/sssd that referenced this issue Aug 12, 2020
In case CONFDB_DOMAIN_ENABLED option was set to a value other than
"true"/"false", function would return EOK while leaving `_enabled`
uninitialized.

Resolves:
SSSD#4743
pbrezina pushed a commit that referenced this issue Sep 4, 2020
In case CONFDB_DOMAIN_ENABLED option was set to a value other than
"true"/"false", function would return EOK while leaving `_enabled`
uninitialized.

Resolves:
#4743

Reviewed-by: Sumit Bose <sbose@redhat.com>
@pbrezina
Copy link
Member

pbrezina commented Sep 4, 2020

Pushed PR: #5270

  • master
    • fbc7082 - CONFDB: fixed bug in confdb_get_domain_enabled()
    • 83ae345 - CONFDB: fixed compilation warning

madhuriupadhye added a commit to madhuriupadhye/sssd that referenced this issue Dec 2, 2020
Configure multiple domain and check 'enabled' parameter.
It consists of 4 test cases:
1. Add 'enabled = true' in both ldap domains and check userlookups.
2. Check userlookup when 'domains = ldap1' and add 'enabled =
   true' in both ldap1, ldap2 section.
3. Check userlookup when enabled option in snippet file and
   'domains = ' in sssd section.
4. Check userlookup when enabled option is set true in snippet
   file

Verifies:
  Issue: SSSD#4743
  Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1884196

Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>
sumit-bose pushed a commit that referenced this issue Dec 16, 2020
Configure multiple domain and check 'enabled' parameter.
It consists of 4 test cases:
1. Add 'enabled = true' in both ldap domains and check userlookups.
2. Check userlookup when 'domains = ldap1' and add 'enabled =
   true' in both ldap1, ldap2 section.
3. Check userlookup when enabled option in snippet file and
   'domains = ' in sssd section.
4. Check userlookup when enabled option is set true in snippet
   file

Verifies:
  Issue: #4743
  Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1884196

Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>

Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com>
akuster pushed a commit to akuster/sssd that referenced this issue May 18, 2021
Configure multiple domain and check 'enabled' parameter.
It consists of 4 test cases:
1. Add 'enabled = true' in both ldap domains and check userlookups.
2. Check userlookup when 'domains = ldap1' and add 'enabled =
   true' in both ldap1, ldap2 section.
3. Check userlookup when enabled option in snippet file and
   'domains = ' in sssd section.
4. Check userlookup when enabled option is set true in snippet
   file

Verifies:
  Issue: SSSD#4743
  Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1884196

Signed-off-by: Madhuri Upadhye <mupadhye@redhat.com>

Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants