sssd-common: missing comma in file sssd_functions.stp

[avisiedo]

William Cohen detected an error at sssd_functions and provided a patch for it. Thank you William.

https://bugzilla.redhat.com/show_bug.cgi?id=1840194

---

patch to insert missing comma in file

Description of problem:

When running systemtap testsuite on fedora rawhide I saw a lot of failures. Like the following:

FAIL: abort: TEST 5: abort() in the middle of a probe handler body (--compatible 3.3): stderr: fails to match regex "^semantic error: unresolved function (similar: [^\n]?): identifier 'abort' at [^\n]?.stp:3:5\n": got "parse error: expected 'probe', 'global', 'private', 'function', or '%{'
saw: identifier 'METHOD_SENTINEL' at /usr/share/systemtap/tapset/sssd_functions.stp:10:34
source: METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10
^

1 parse error.
WARNING: tapset "/usr/share/systemtap/tapset/sssd_functions.stp" has errors, and will be skipped
Pass 2: analysis failed. [man error::pass2]
"
FAIL: abort: TEST 7: abort() in timer.profile (more concurrency and no globals): stderr: string should be "", but got "parse error: expected 'probe', 'global', 'private', 'function', or '%{'
saw: identifier 'METHOD_SENTINEL' at /usr/share/systemtap/tapset/sssd_functions.stp:10:34
source: METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10
^

1 parse error.
WARNING: tapset "/usr/share/systemtap/tapset/sssd_functions.stp" has errors, and will be skipped
"

Version-Release number of selected component (if applicable):

How reproducible:

every time

Steps to Reproduce:

1. dnf install systemtap-testsuite kernel-devel
2. dnf debuginfo kernel
3. sudo stap -e 'probe timer.profile {
   abort();
   error("fire after abort!\n")
   }'

Actual results:

parse error: expected 'probe', 'global', 'private', 'function', or '%{'
saw: identifier 'METHOD_SENTINEL' at /usr/share/systemtap/tapset/sssd_functions.stp:10:34
source: METHOD_RESOLVER_HANDLER=9 METHOD_SENTINEL=10
^

1 parse error.
WARNING: tapset "/usr/share/systemtap/tapset/sssd_functions.stp" has errors, and will be skipped

Expected results:

$ sudo stap -e 'probe timer.profile {
abort();
error("fire after abort!\n")
}'

Additional info:

Looks like a trivial missing comma to fix the issue.

[alexey-tikhonov]

RHBZs:

• https://bugzilla.redhat.com/show_bug.cgi?id=1840194
• https://bugzilla.redhat.com/show_bug.cgi?id=1850961

[pbrezina]

Pushed PR: #5202

• master
  • 6602952 - systemtap: Missing a comma