Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate SSSD's version of libwbclient #5230

Closed
sumit-bose opened this issue Jul 7, 2020 · 7 comments
Closed

Deprecate SSSD's version of libwbclient #5230

sumit-bose opened this issue Jul 7, 2020 · 7 comments
Assignees
@sumit-bose
Labels
Bugzilla Closed: Fixed Issue was closed as fixed.

Comments

@sumit-bose
Copy link
Contributor

SSSD's implementation of libwbclient was added to allow Samba's smbd to get user and group information from AD without the need to run winbinbd. It was added at a time where smbd was able to handle other required communication with AD not related to user and group lookups on its own. This changed and now it is required that winbind is running and handling to communication with AD since the related code in smbd was removed for security reasons and to avoid code duplication.

Since there are no plans to add the additional required functionality to SSSD and SSSD's version of libwbclient it cannot be used with recent versions of Samba and should be deprecated.

To allow SSSD to work together with winbindd running on the same host an id-mapping plugin for winbind can be used, see man idmap_sss for details.
sumit-bose added a commit to sumit-bose/sssd that referenced this issue Jul 7, 2020
@sumit-bose
libwbclient-sssd: deprecate libwbclient-sssd
1a47b21 
Recent version of Samba require that winbindd is running to handle the
communication with AD. SSSD's implementation of libwbclient cannot be
used anymore in this case and should be deprecated so that the related
code can be removed in a later version.

With this patch libwbclient will not be build by default anymore and the
configure help messages indicates that libwbclient is deprecated.

Resolves: SSSD#5230
@sumit-bose sumit-bose mentioned this issue Jul 7, 2020
Closed
@alexey-tikhonov
Copy link
Member

Fedora BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1854469

@pbrezina
Copy link
Member

pbrezina commented Jul 9, 2020

Does this affect only rawhide or also F32?

@alexey-tikhonov
Copy link
Member

Does this affect only rawhide or also F32?

If I understood Sumit correctly, the idea was to deprecate e.g. in F33 and remove in F34.

@sumit-bose
Copy link
Contributor Author

Hi,

rawhide is sufficient. If it would be easier to add the same sources to F32 as well I fine adding it to F32 as well. Please note that you now have to explicitly enable the build of the library with the configure option.

bye,
Sumit

@pbrezina
Copy link
Member

pbrezina commented Jul 9, 2020

So if libwbclient can be used with Samba on F32 I think we should leave it there so those that already use it are not affected.

@sumit-bose
Copy link
Contributor Author

So if libwbclient can be used with Samba on F32 I think we should leave it there so those that already use it are not affected.

Hi,

I won't expect that it can be used with Samba on F32 in a productive way, but we should not remove it from an already release version. Additionally, when we plan to remove the related sub-packages it has to be tested that the alternatives configuration is cleaned up as expected.

bye,
Sumit

@pbrezina
Copy link
Member

Pushed PR: #5231

  • master
    • 41a60c6 - libwbclient-sssd: deprecate libwbclient-sssd

@pbrezina pbrezina added the Closed: Fixed Issue was closed as fixed. label Jul 23, 2020
@alexey-tikhonov alexey-tikhonov mentioned this issue Jan 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sumit-bose sumit-bose

Labels
Bugzilla Closed: Fixed Issue was closed as fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libwbclient-sssd: deprecate libwbclient-sssd sumit-bose/sssd
3 participants
@sumit-bose @pbrezina @alexey-tikhonov