Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial revision of sssd pytest framework #139

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@mrniranjan
Copy link

commented Jan 28, 2017

sssd-testlib: library containing shared functions to automtate
sssd using pytest

copr: https://copr.fedorainfracloud.org/coprs/mrniranjan/sssd-testlib/

Signed-off-by: Niranjan M.R mrniranjan@redhat.com

@centos-ci

This comment has been minimized.

Copy link
Collaborator

commented Jan 28, 2017

Can one of the admins verify this patch?

1 similar comment
@centos-ci

This comment has been minimized.

Copy link
Collaborator

commented Jan 28, 2017

Can one of the admins verify this patch?

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2017

ok to test

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2017

Looking at the patches I see this can be a completely new library instead of being part of SSSD.
Knowing this it does make sense to have it as a submodule or even a completely external library (but still under SSSD group).

I'd like to know the opinion of the more experienced developers about this.

@lslebodn

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2017

There are some trailing white spaces

sh$ ABS_TOP_SRCDIR=$PWD src/tests/whitespace_test 
Trailing whitespace found:
src/tests/python/README.rst:4:`sssd.testlib`_ is a library containing shared functions to automtate `System Services Security Daemon __` using pytest framework.

and pep8 warnings. We try to follow pep8 for new python code

sh$ find  src/tests/python/ -name "*.py" | xargs pep8  | wc -l
249
@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2017

@lslebodn

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2017

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2017

@lslebodn

This comment has been minimized.

Copy link
Contributor

commented Feb 2, 2017

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Feb 3, 2017

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Feb 7, 2017

I will submit the changes (i.e fixing the pep8 and pylint errors), I am awaiting the changes to be merged downstream first.

@lslebodn

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2017

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2017

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Feb 8, 2017

This whole effort is to write test cases for features upstream and pull it downstream . And the upstream builds are tested against the testcases written in upstream as well as downstream to check if there are any regressions.

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2017

@mrniranjan @lslebodn it seems that this patch set got a bit stuck. Are the major issues the pep8 warnings and the whitespace issues? If yes, can @mrniranjan respin the patch so that we move forward?

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Feb 22, 2017

@lslebodn @jhrozek i have an internal fix for pep8 and whitespaces, and also a lot of pylint fixes are pending internal review. i will try to send a revised patch by this week.

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Mar 3, 2017

I have updated the PR with pep8,pylint fixes, please have a look and let me know how we can move forward

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Mar 4, 2017

@lslebodn @jhrozek you can have a look at the documentation of sssd-testlib at https://mrniranjan.fedorapeople.org/sssd-docs/

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Mar 21, 2017

Any update on this ?

@lslebodn

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2017

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Apr 27, 2017

Any update on this ?

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Jun 29, 2017

@lslebodn @jhrozek can you have a look at this initial revision,

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Aug 16, 2017

@lslebodn @jhrozek any update on this.

@lslebodn

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2017

I'll check it next week. I didn't expect so many downstream bug reports :-(

@fidencio fidencio self-assigned this Oct 17, 2017

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Oct 23, 2017

@mrniranjan: Can you update this patchset according to what we discussed in our call last week?

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Oct 24, 2017

Have updated the patchset, but the build failed to finish, from the console, i could not make out exact reason for failure.

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2017

@mrniranjan, could you send me (could be by email) the instructions/ansible scripts that you've been using to provision the machines, as we've talked via IRC? That would help me a lot by saving some time during this review process.

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Nov 13, 2017

@lslebodn @fidencio any update on this.

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2017

@mrniranjan, no updates on this at all.

Although it's on top of my TODO list, downstream work has been prioritized (sorry about that).

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2017

So, just by running pep8 in the python files I've seen:

[ffidenci@pessoa sssd]$ pep8 src/tests/multihost/basic/conftest.py src/tests/multihost/basic/test_basic.py src/tests/python/docs/conf.py src/tests/python/setup.py src/tests/python/sssd/__init__.py src/tests/python/sssd/testlib/__init__.py src/tests/python/sssd/testlib/common/__init__.py src/tests/python/sssd/testlib/common/authconfig.py src/tests/python/sssd/testlib/common/exceptions.py src/tests/python/sssd/testlib/common/libdirsrv.py src/tests/python/sssd/testlib/common/libkrb5.py src/tests/python/sssd/testlib/common/qe_class.py src/tests/python/sssd/testlib/common/utils.py
src/tests/multihost/basic/conftest.py:28:1: E302 expected 2 blank lines, found 1
src/tests/multihost/basic/conftest.py:48:1: E302 expected 2 blank lines, found 1
src/tests/multihost/basic/conftest.py:59:1: E302 expected 2 blank lines, found 1
src/tests/multihost/basic/conftest.py:68:1: E302 expected 2 blank lines, found 1
src/tests/multihost/basic/conftest.py:79:1: E302 expected 2 blank lines, found 1
src/tests/multihost/basic/conftest.py:113:80: E501 line too long (89 > 79 characters)
src/tests/multihost/basic/conftest.py:129:80: E501 line too long (82 > 79 characters)
src/tests/multihost/basic/conftest.py:130:80: E501 line too long (82 > 79 characters)
src/tests/multihost/basic/test_basic.py:29:80: E501 line too long (82 > 79 characters)
src/tests/multihost/basic/test_basic.py:60:80: E501 line too long (87 > 79 characters)
src/tests/multihost/basic/test_basic.py:66:80: E501 line too long (84 > 79 characters)
src/tests/multihost/basic/test_basic.py:73:80: E501 line too long (87 > 79 characters)
src/tests/multihost/basic/test_basic.py:83:80: E501 line too long (85 > 79 characters)
src/tests/python/docs/conf.py:22:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:27:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:32:1: E302 expected 2 blank lines, found 1
src/tests/python/docs/conf.py:37:1: E302 expected 2 blank lines, found 1
src/tests/python/docs/conf.py:40:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:46:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:68:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:96:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:98:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:106:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:109:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:113:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:117:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:123:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:126:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:136:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:137:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:143:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:146:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:150:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:153:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:157:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:162:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:172:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:176:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:180:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:183:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:187:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:190:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:193:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:196:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:199:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:202:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:205:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:210:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:213:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:219:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:223:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:227:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:235:1: E122 continuation line missing indentation or outdented
src/tests/python/docs/conf.py:236:1: E122 continuation line missing indentation or outdented
src/tests/python/docs/conf.py:236:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:238:1: E122 continuation line missing indentation or outdented
src/tests/python/docs/conf.py:239:1: E122 continuation line missing indentation or outdented
src/tests/python/docs/conf.py:239:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:241:1: E122 continuation line missing indentation or outdented
src/tests/python/docs/conf.py:242:1: E122 continuation line missing indentation or outdented
src/tests/python/docs/conf.py:242:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:244:1: E122 continuation line missing indentation or outdented
src/tests/python/docs/conf.py:245:1: E122 continuation line missing indentation or outdented
src/tests/python/docs/conf.py:245:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:258:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:262:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:265:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:268:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:271:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:274:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:281:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:284:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:287:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:302:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:305:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:308:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:311:1: E265 block comment should start with '# '
src/tests/python/docs/conf.py:314:1: W391 blank line at end of file
src/tests/python/setup.py:18:13: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:18:15: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:19:16: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:19:18: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:20:20: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:20:22: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:21:25: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:21:27: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:22:15: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:22:17: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:23:12: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:23:14: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:24:17: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:24:19: E251 unexpected spaces around keyword / parameter equals
src/tests/python/setup.py:29:25: E231 missing whitespace after ':'
src/tests/python/sssd/testlib/common/authconfig.py:144:80: E501 line too long (80 > 79 characters)
src/tests/python/sssd/testlib/common/exceptions.py:28:80: E501 line too long (95 > 79 characters)
src/tests/python/sssd/testlib/common/exceptions.py:34:80: E501 line too long (90 > 79 characters)
src/tests/python/sssd/testlib/common/exceptions.py:40:80: E501 line too long (89 > 79 characters)
src/tests/python/sssd/testlib/common/libdirsrv.py:185:1: E101 indentation contains mixed spaces and tabs
src/tests/python/sssd/testlib/common/libdirsrv.py:185:1: W191 indentation contains tabs
src/tests/python/sssd/testlib/common/libdirsrv.py:186:1: E101 indentation contains mixed spaces and tabs
src/tests/python/sssd/testlib/common/libdirsrv.py:186:80: E501 line too long (80 > 79 characters)
src/tests/python/sssd/testlib/common/libdirsrv.py:189:5: E303 too many blank lines (2)
src/tests/python/sssd/testlib/common/libdirsrv.py:368:80: E501 line too long (93 > 79 characters)
src/tests/python/sssd/testlib/common/libkrb5.py:58:80: E501 line too long (81 > 79 characters)
src/tests/python/sssd/testlib/common/libkrb5.py:106:80: E501 line too long (95 > 79 characters)
src/tests/python/sssd/testlib/common/libkrb5.py:118:80: E501 line too long (95 > 79 characters)
src/tests/python/sssd/testlib/common/libkrb5.py:123:80: E501 line too long (96 > 79 characters)
src/tests/python/sssd/testlib/common/libkrb5.py:129:80: E501 line too long (99 > 79 characters)
src/tests/python/sssd/testlib/common/libkrb5.py:215:80: E501 line too long (80 > 79 characters)
src/tests/python/sssd/testlib/common/qe_class.py:178:80: E501 line too long (82 > 79 characters)
src/tests/python/sssd/testlib/common/qe_class.py:209:80: E501 line too long (87 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:104:80: E501 line too long (80 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:117:80: E501 line too long (85 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:260:80: E501 line too long (95 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:261:80: E501 line too long (101 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:262:1: E101 indentation contains mixed spaces and tabs
src/tests/python/sssd/testlib/common/utils.py:262:1: W191 indentation contains tabs
src/tests/python/sssd/testlib/common/utils.py:263:1: E101 indentation contains mixed spaces and tabs
src/tests/python/sssd/testlib/common/utils.py:272:80: E501 line too long (80 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:279:80: E501 line too long (86 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:307:80: E501 line too long (82 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:331:80: E501 line too long (88 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:350:80: E501 line too long (82 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:457:80: E501 line too long (81 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:462:80: E501 line too long (85 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:643:80: E501 line too long (81 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:662:80: E501 line too long (80 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:664:80: E501 line too long (81 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:680:80: E501 line too long (81 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:697:80: E501 line too long (86 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:720:80: E501 line too long (80 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:736:80: E501 line too long (88 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:737:80: E501 line too long (87 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:738:80: E501 line too long (86 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:741:80: E501 line too long (86 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:742:80: E501 line too long (87 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:743:80: E501 line too long (104 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:764:80: E501 line too long (81 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:771:80: E501 line too long (93 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:782:80: E501 line too long (84 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:785:80: E501 line too long (83 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:811:80: E501 line too long (83 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:878:80: E501 line too long (86 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:896:80: E501 line too long (85 > 79 characters)
src/tests/python/sssd/testlib/common/utils.py:909:80: E501 line too long (80 > 79 characters)
@fidencio

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2017

retest this, please

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2017

whitespace tests failed, please, take a look at: http://vm-031.${abc}/logs/job/81/13/summary.html

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Nov 14, 2017

I have fixed most of the errors suggested, i would like if you we don't enforce 80chars limit, the readeability really hampers, Can we have 90 or 100 character limit .

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Nov 14, 2017

I am unable to access the link given

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2017

@mrniranjan, on SSSD we, at least, try enforce 80. You can see by the #379.

So, in case we have that PR merged, we'd be officially enforcing 80 chars. But that's something I'll leave for @lslebodn to answer what are his preferences.

About the link, I'm sending you a message in the internal IRC (as there's no private comment on github)

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2017

I've been able to test the patches with some documentation sent by @mrniranjan. As this documentation is related to provisioning downstream infra, it's not worth (nor allowed) to have it published upstream.

The PR works as expected but I'd like to ask for a few changes:

  • Please, if it makes sense for you, squash fidencio@6db7bcf into your patch
  • Please, remove the generated html docs

Once it's done, please, re-submit the PR and let's be sure our internal CI passes and I'll give it my Ack!

Thanks a lot for your work and for your patience!

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Nov 15, 2017

Thanks will apply the changes suggested and resend the patch

Niranjan M.R
Initial revision of sssd pytest framework
sssd-testlib: library containing shared functions to automtate
sssd using pytest

Basic Multihost test cases.

Note: Multihost test cases can only be run inside Red Hat network
currently.

Minor fixes and rebased code from current downstream.
Minor fixes to basic sanity tests
Modify sssd-testlib and add new basic testcases.
Minor fixes to Documentation,
Add html Documentation.
Minor fixes based on review comments
Add fixes specified by devel
Remove static html pages
Remove whitelines

copr: https://copr.fedorainfracloud.org/coprs/mrniranjan/sssd-testlib/

Signed-off-by: Niranjan M.R <mrniranjan@redhat.com>
@fidencio

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2017

Ack!

@fidencio fidencio added the Accepted label Nov 15, 2017

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2017

With this code being pushed I'd like to ask for:

  • Add @mrniranjan as SSSD mantainer
  • Create a pagure session for issues related to this code

@jhrozek, could you do both?

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2017

Sure, but I'm not sure what exactly I'm supposed to do :-)

What exact permissions does @mrniranjan need? Does this include push privileges in order to push patches? (IIRC when we were on the phone a couple of weeks ago, we agreed that the tests would be reviewed by people currently working on the test development and not necessarily the "sssd deamon" developers)

What do you mean with pagure session? Account permissions there? Should we also have tags and/or a milestone about the tests?

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2017

So, based that the tests would be reviewed by people currently working on the test development, at least in the beginning, I'd like that @mrniranjan could have push access to SSSD in order to avoid their PRs being blocked/waiting for us to push.

Also, I'd like them to have rights to push documentation in our pagure website (so, the docs repo).

And tags would be better than milestones, I guess. Also, a "test" tag on github in order to make easier to distinguish which are the PRs coming for those tests and which are the PRs coming from the "sssd daemon".

Do these suggestions make sense?

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2017

Sure, thanks for the clarification.

About the push privileges, I would just prefer to drop a mail to sssd-devel before granting push privileges to someone who was not previously much involved in the sssd upstream work. Of cource I trust @mrniranjan to not cause any trouble :-) but I still think it would be nice to let people know why are we granting these push privileges.

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Nov 16, 2017

Till we have some idea on the review process, the directory structure of where tests should be pushed and how to run those tests , i am okay with not having PUSH access.

Also a couple of points i would like to make.

  1. This code here has been a team effort and internal SSSD QE have contributed to this framework/code. Though i have pushed this code from my github account, there have been contributions as well from other SSSD QE engineers.

  2. With regard to PUSH access and review process, All the SSSD QE Engineers submit their code individually through their github accounts and raise PR's and devel reviews and PUSH . Over a period of time we can review the PUSH access and once we have a decent set of test cases that we are able to run reliably , we can review the push access.

I will discuss this internally on how we can do review before we submit our tests.

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2017

OK, I added @mrniranjan to commit group for https://pagure.io/SSSD/docs/

Then I created the tag "tests" in pagure and added @mrniranjan to the main pagure repo with "ticket" privileges.

I also wonder if we should add a new github team where we would initially add @mrniranjan but also anyone else who would be sending PRs for the pytests. One advantage of having a team is that you can @mention the whole team and set granular permissions for the whole team.

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2017

I really like the idea of having the team there. So, +1 from me.

@mrniranjan

This comment has been minimized.

Copy link
Author

commented Nov 16, 2017

+1 from me for team

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2017

@jhrozek jhrozek closed this Nov 21, 2017

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2017

OK, I created a team "Test Developers" and added @mrniranjan there.

Please let me know what other people should be added. Also, I'm OK with granting the push rights, just let me know what suits you best.

@jhrozek jhrozek added the Pushed label Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.