Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module for starting services #175

Open
wants to merge 2 commits into
base: master
from
Open

Conversation

@lslebodn
Copy link
Contributor

lslebodn commented Mar 2, 2017

This is a WIP version of reducing code duplication in our cwrap integration tests.

I am still not sure whether we should also reuse function create_sssd_fixture.
And if yes; then probably in different nodule then services

And comments are welcome.

BTW I wrote patches few weeks ago; therefore new tests are not converted.
I am just sending patches to get some feedback.

Site effect of this patches is that tests are cca 20% faster (IIRC)

Lukas Slebodnik added 2 commits Jan 9, 2017
ATM; there is just a class for sssd
@jhrozek

This comment has been minimized.

Copy link
Contributor

jhrozek commented Mar 7, 2017

I think this is a really nice refactor. I also think that the LDAP server could be another service, but I'm not sure if we want to mix all services in a single file. Would it make more sense to create a services/ package and add sssd.py, openldap.py, krb5.py (this is from KCM) there? Maybe some code could be shared between the services like spawning a generic program and killing it later pased on its PID.

About the fixture, I would definitely split it out to a module as well, but I think moving it to fixtures.py (a new file) would make more sense.

@fidencio

This comment has been minimized.

Copy link
Contributor

fidencio commented May 2, 2017

I'm adding "Changes requested" label by @jhrozek's review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.