SSSD-1.15 - config-check: Message when sssd.conf is missing #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssctl config-check should print a message for user if no sssd.conf was found. Resolves: https://pagure.io/SSSD/sssd/issue/3330
lslebodn
reviewed
Mar 15, 2017
src/tools/sssctl/sssctl_config.c
Outdated
| if (ret != EOK) { | ||
| if (ret == ENOENT) { | ||
| PRINT("File %1$s does not exist. Default configuration will be " | ||
| "generated on next SSSD startup.\n", SSSD_CONFIG_FILE); |
There was a problem hiding this comment.
just confd is generated on startup; /etc/sssd/sssd.conf is not generated
Print different message when SSSD was configured with --enable-files-domain. Resolves: https://pagure.io/SSSD/sssd/issue/3330
mzidek-gh
force-pushed
the
sssctl-config-check-no-sssd.conf-1-15
branch
from
a44a1d8
to
99c3000
Compare
|
I just realized that the message needs to be printed conditionally only if SSSD was configured with --enable-files-domain . I tested it in both cases. Also no longer use the word "generated", because as Lukas mentioned it is not really what is happening. |
|
On (15/03/17 07:53), mzidek-rh wrote:
I just realized that the message needs to be printed conditionally only if SSSD was configured with --enable-files-domain . I tested it in both cases. Also no longer use the word "generated", because as Lukas mentioned it is not really what is happening.
That woudl be OK; BUT .. (not related to your patch)
man page sssd.conf says (XML version):
```
<term>enable_files_domain (boolean)</term>
<listitem>
<para>
When this option is enabled, SSSD
prepends an implicit domain with
<quote>id_provider=files</quote> before
any explicitly configured domains.
</para>
<para condition="no_enable_files_domain">
Default: false
</para>
<para condition="enable_files_domain">
Default: true
</para>
```
According to man page `#ifdef ADD_FILES_DOMAIN` should just prepend implicit
files domains. It should not be related to missing sssd.conf
IMHO we should fix missing sssd.conf with --disable-files-domain
because `libsss_files.so` is build every time.
LS
|
|
Sorry, I do not understand your last comment. Can you please summarize it in an pagure issue? I am little bit confused (but if I understand it correctly it does not affect the PR, right?) I did not update the patches, please tell me if you think I should. |
|
On (15/03/17 09:45), mzidek-rh wrote:
Sorry, I do not understand your last comment. Can you please summarize it in an pagure issue? I am little bit confused (but if I understand it correctly it does not affect the PR, right?)
I did not update the patches, please tell me if you think I should.
IMHO; it depends on https://pagure.io/SSSD/sssd/issue/3340
https://pagure.io/SSSD/sssd/issue/3339
Because message might change after fixing these tickets.
LS
|
|
Thank you for summarizing it in the pagure issues. is it OK, if I send patches for the issues you mentioned in this PR as part of the review process? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSSD 1.15 version for patch recently pushed to 1.14.
sssctl config-check should print a message for user
if no sssd.conf was found.
Resolves:
https://pagure.io/SSSD/sssd/issue/3330