Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFP: Fix of names in GetUserGroups method #240

Closed
wants to merge 2 commits into from

Conversation

@jhrozek
Copy link
Contributor

commented Apr 19, 2017

This is a continuation of PR#206 that implements the suggestion brought up there during PR review.

This PR fixes https://pagure.io/SSSD/sssd/issue/3268

jhrozek added 2 commits Apr 19, 2017
Move sized_output_name() and sized_domain_name() into responder commo…
…n code

These functions are used to format a name into a format that the user
configured for output, including case sensitiveness, replacing
whitespace and qualified format. They were used only in the NSS
responder, which typically returns strings to the NSS client library and
then the user.

But it makes sense to just reuse the same code in the IFP responder as
well, since it does essentially the same job.

The patch also renames sized_member_name to sized_domain_name.
Previously, the function was only used to format a group member, the IFP
responder would use the same function to format a group the user is a
member of.

Related to:
    https://pagure.io/SSSD/sssd/issue/3268
IFP: Use sized_domain_name to format the groups the user is a member of
Resolves:
    https://pagure.io/SSSD/sssd/issue/3268

Uses the common function sized_domain_name() to format a group the user
is a member of to the appropriate format.

To see the code is working correctly, run:
        dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe
                  /org/freedesktop/sssd/infopipe
                  org.freedesktop.sssd.infopipe.GetUserGroups
                  string:trusted_user

Where trusted_user is a user from a trusted domain that is a member of groups
from the joined domain and a trusted domain as well. The groups from the
joined domain should not be qualified, the groups from the trusted
domain should be qualified.
@pbrezina

This comment has been minimized.

Copy link
Member

commented Apr 20, 2017

Ack.

@jhrozek jhrozek closed this Apr 21, 2017

@jhrozek jhrozek deleted the jhrozek:ifp_names branch Jan 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.