Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove CONFDB_DOMAIN_LEGACY_PASS #397

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@amitkumar50
Copy link
Contributor

commented Oct 3, 2017

Since CONFDB_DOMAIN_LEGACY_PASS is legacy parameter that is rooted in pre-1.0 SSSD. We should just nuke it as we remove other legacy code.

Resolves: https://pagure.io/SSSD/sssd/issue/3530

@centos-ci

This comment has been minimized.

Copy link
Collaborator

commented Oct 3, 2017

Can one of the admins verify this patch?

1 similar comment
@centos-ci

This comment has been minimized.

Copy link
Collaborator

commented Oct 3, 2017

Can one of the admins verify this patch?

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2017

Would be sending commit to remove 'domain->legacy_passwords' and related code.

@lslebodn

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2017

@amitkumar50 amitkumar50 force-pushed the amitkumar50:branch-3530 branch from 9c73186 to 4112e95 Oct 3, 2017

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2017

@lslebodn Done Thanks.

@amitkumar50 amitkumar50 force-pushed the amitkumar50:branch-3530 branch from 4112e95 to 011fb3e Aug 1, 2018

@fidencio
Copy link
Contributor

left a comment

@amitkumar50,
src/config/SSSDConfig/sssd_upgrade_config.py has been removed as part of fb22e59. Please, do not re-introduce this file.

Apart from this, there's one more comment inline.

ret = sysdb_attrs_add_string(attrs, SYSDB_PWD, pwd);
if (ret) goto done;
}

This comment has been minimized.

Copy link
@fidencio

fidencio Aug 1, 2018

Contributor

Please, do not remove this code entirely. Only the check for domain->legacy_passwords should be removed.
So, you'll end up with something like:

if (pwd && !*pwd) {
   ...
}

@amitkumar50 amitkumar50 force-pushed the amitkumar50:branch-3530 branch from 011fb3e to 5abac42 Aug 7, 2018

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2018

@fidencio Done Changes.

@fidencio fidencio force-pushed the amitkumar50:branch-3530 branch 2 times, most recently from 9b4c8eb to d212d64 Aug 7, 2018

@fidencio fidencio added Accepted and removed Changes requested labels Aug 7, 2018

@fidencio fidencio removed the Accepted label Aug 7, 2018

confdb: Remove CONFDB_DOMAIN_LEGACY_PASS
As CONFDB_DOMAIN_LEGACY_PASS is legacy parameter that is rooted in
pre-1.0 SSSD, let's just nuke it now as we're already removing other
legacy code.

Resolves:
https://pagure.io/SSSD/sssd/issue/3530

@fidencio fidencio force-pushed the amitkumar50:branch-3530 branch from d212d64 to a40dea9 Aug 7, 2018

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2018

@fidencio fidencio added the Accepted label Aug 7, 2018

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2018

@jhrozek jhrozek closed this Aug 13, 2018

@jhrozek jhrozek added the Pushed label Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.