mmap_cache: add SID and type to struct sss_mc_rec #413
This patchset updates the memory cache by adding some new members to struct
The other is a new record type and a member indicating the type. The new type
Besides aliases this link record will be used in case in-sensitive setups. E.g.
The last patch in this series adds some additional data to the user and group
/* - * 40 seem a good compromise for slot size - * 4 blocks are enough for the average passwd entry of 42 bytes - * passwd records have 84 bytes of overhead, 160 - 82 = 78 bytes - * 3 blocks can contain a very minimal entry, 120 - 82 = 38 bytes + * 48 seem a good compromise for slot size + * 4 blocks are more than two times the average passwd entry of 42 bytes + * passwd records have 84 bytes of overhead, 192 - 82 = 110 bytes + * 3 blocks can contain a typical entry, 144 - 82 = 62 bytes * * 3 blocks are enough for groups w/o users (private user groups) - * group records have 68 bytes of overhead, 120 - 66 = 54 bytes + * group records have 68 bytes of overhead, 144 - 66 = 78 bytes */ #define MC_SLOT_SIZE 40
You have changed it to
There are also some questions raised inside the code, it would be better to resolve them. But I will let someone who understands memory cache better to review this patch set.
simo5 left a comment
I am not sure I really like the link data type record concept or the extra data I see in this patchset.