LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we weren't treating the errors coming from sdap_cli_connect_recv() properly we ended up introducing a regression in the commit add7286, related to offline authentication. From now on, let's properly treat errors coming from auth_connect_send(), which were treated before by going offline when be_resolve_server_recv() failed, and propagate ETIMEDOUT to the request, thus going offline and allowing offline authentication on those cases. Related: https://pagure.io/SSSD/sssd/issue/3451 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
|
I've ran two downstream tests and both passed successfully:
If you guys have some idea about a better set of downstream tests to run, please, ping me in private with the link that I could clone. |
|
The patch makes sense and passes the CI (with the current exception on F27 and rawhide caused by the newer libldb). ACK @fidencio, please let me know when you have the results of the regression test. |
|
@sumit-bose I'm waiting for results of tests. I'll push the patch after good results with your ACK |
|
@lslebodn, thanks, shall I set the Accepted flag or will you do it? |
|
There were some random failures which I did not see before. But it worked well after re-executing problematic jobs 5 times. I hope it was not related :-) |
|
master: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we weren't treating the errors coming from
sdap_cli_connect_recv() properly we ended up introducing a regression in
the commit add7286, related to offline authentication.
From now on, let's properly treat errors coming from auth_connect_send(),
which were treated before by going offline when be_resolve_server_recv()
failed, and propagate ETIMEDOUT to the request, thus going offline and
allowing offline authentication on those cases.
This patch fixes the regression reported by Lukáš on https://bugzilla.redhat.com/show_bug.cgi?id=1459609#c9. (And I have to say a big thanks for finding this out!)
Related:
https://pagure.io/SSSD/sssd/issue/3451
Signed-off-by: Fabiano Fidêncio fidencio@redhat.com