systemtap: Missing a comma #5202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to mentioned the original author in the commit message and link to the patch he submitted. |
avisiedo
force-pushed
the
wip/5201-sssd_functions-missing-comma
branch
from
6eac147
to
006a8e5
Compare
|
Hi @avisiedo, could you please also add "Resolves: " before the link to upstream issue in the commit message? This would automatically link PR to the issue. |
sssd_functions.stp was missing a comma. Thanks to William Cohen for reporting the issue and the patch to fix it. https://bugzilla.redhat.com/show_bug.cgi?id=1840194 Resolves: SSSD#5201
avisiedo
force-pushed
the
wip/5201-sssd_functions-missing-comma
branch
from
006a8e5
to
10255d8
Compare
Done! Thanks @alexey-tikhonov |
pbrezina
added
Accepted
Ready to push
|
Thank you. I added back accepted label since only commit message was changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sssd_functions.stpwas missing a comma.Thanks to William Cohen for reporting the issue and the patch to fix it.
https://bugzilla.redhat.com/show_bug.cgi?id=1840194
Resolves: #5201