Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils: White space replace with another character #5264

Closed
wants to merge 1 commit into from

Conversation

elkoniu
Copy link
Contributor

@elkoniu elkoniu commented Aug 6, 2020

Function responsible for replacing white space
has wrong log levels set. It can create false positive
critical error messages broadcasted across the system
without any real reason.

This patch adjusts those log levels to be on the debug
level rather than criticar error level.

Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1818671

Function responsible for replacing white space
has wrong log levels set. It can create false positive
critical error messages broadcasted across the system
without any real reason.

This patch adjusts those log levels to be on the debug
level rather than criticar error level.

Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1818671
@pbrezina
Copy link
Member

I think this is not a correct solution since having the override character in name is in fact a real problem in the environment. It will either make the user unresolvable or even worse it will return different user if you have both names "user_1" and "user 1" in LDAP.

I think the root cause is that this option is set globally for the whole SSSD and ssh_keys is a local user. If it is a local user then we should probably figure out if we can somehow avoid using this override for files provider. If it is an LDAP user then they need to fix it on their side.

@alexey-tikhonov
Copy link
Member

Setting flags based on #5264 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants