cache_req: ignore autofs not configured error #5462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we return ERR_OFFLINE for domains where autofs provider is not set (such as implicit files domain) which is undesirable. Steps to reproduce: 1. Enable implicit files domains and LDAP domain with autofs configured 2. Setup NFS server to export `/exports` with `/exports/home/test` 3. Add autofs mount points: ``` dn: ou=mount,dc=ldap,dc=vm ou: mount objectClass: organizationalUnit objectClass: top dn: nisMapName=auto.master,ou=mount,dc=ldap,dc=vm objectClass: nisMap objectClass: top nisMapName: auto.master dn: cn=/export/home,nisMapName=auto.master,ou=mount,dc=ldap,dc=vm objectClass: nisObject objectClass: top cn: /export/home nisMapEntry: auto.home nisMapName: auto.master dn: nisMapName=auto.home,ou=mount,dc=ldap,dc=vm objectClass: nisMap objectClass: top nisMapName: auto.home dn: cn=/,nisMapName=auto.home,ou=mount,dc=ldap,dc=vm objectClass: nisObject objectClass: top cn: / nisMapEntry: -fstype=nfs,rw master.ldap.vm:/export/home/& nisMapName: auto.home ``` 4. Run SSSD and autofs 5. cd to /exports/home/test The directory will not be mounted with the new autofs protocol. It will succeed with the old protocol. In both versions, you'll see that SSSD returned ERR_OFFLINE: ``` (2021-01-15 11:44:48): [be[implicit_files]] [sbus_issue_request_done] (0x0040): sssd.DataProvider.Autofs.GetEntry: Error [1432158215]: DP target is not configured ... (2021-01-15 11:44:49): [autofs] [cache_req_search_cache] (0x0400): CR #3: Looking up [auto.home:test] in cache (2021-01-15 11:44:49): [autofs] [cache_req_search_cache] (0x0400): CR #3: Object [auto.home:test] was not found in cache (2021-01-15 11:44:49): [autofs] [cache_req_search_ncache_add_to_domain] (0x2000): CR #3: This request type does not support negative cache (2021-01-15 11:44:49): [autofs] [cache_req_process_result] (0x0400): CR #3: Finished: Error 1432158212: SSSD is offline ```
|
This is mostly a hotfix and it is fine because |
Does it make sense to open a ticket for this ^^ ? Otherwise patch LGTM. Awaiting results of a test execution. |
|
autofs test suite that failed previously is now fine. ci-make-intgcheck on rawhide fails with "sssd start failed" in most tests.
But this patch - ACK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we return ERR_OFFLINE for domains where autofs provider is not
set (such as implicit files domain) which is undesirable.
Steps to reproduce:
/exportswith/exports/home/testThe directory will not be mounted with the new autofs protocol. It
will succeed with the old protocol. In both versions, you'll see
that SSSD returned ERR_OFFLINE: