Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAM: create pre-auth indicator file #605

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@sumit-bose
Copy link
Contributor

commented Jun 22, 2018

If pam_cert_auth is enabled the PAM responder will automatically create the
pre-authentication indicator file to tell pam_sss to do the pre-auth step to
find out about the available authentication methods.

Related to https://pagure.io/SSSD/sssd/issue/3500

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2018

"The checks were not successful" due to pep8 issues in the integration tests.

@fidencio

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2018

[ffidenci@pessoa sssd]$ pep8 src/tests/intg/test_pam_responder.py
src/tests/intg/test_pam_responder.py:37:1: E303 too many blank lines (3)
src/tests/intg/test_pam_responder.py:115:1: E303 too many blank lines (4)

And ...

[ffidenci@pessoa sssd]$ git diff
diff --git a/src/tests/intg/test_pam_responder.py b/src/tests/intg/test_pam_responder.py
index 0d524b9db..b0892857a 100644
--- a/src/tests/intg/test_pam_responder.py
+++ b/src/tests/intg/test_pam_responder.py
@@ -33,7 +33,6 @@ import config
 from .util import unindent
 
 
-
 def format_pam_cert_auth_conf():
     """Format a basic SSSD configuration"""
     return unindent("""\
@@ -110,8 +109,6 @@ def cleanup_sssd_process():
             raise ex
 
 
-
-
 def create_sssd_fixture(request):
     """Start SSSD and add teardown for stopping it and removing its state"""
     create_sssd_process()
@fidencio

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2018

Patches look good apart from the pep8 issue.

@sumit-bose sumit-bose force-pushed the sumit-bose:preauth_for_certauth branch from 74de22b to 7db8e95 Jun 25, 2018

@sumit-bose

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2018

Hi Fabiano, thanks for the review. I removed the empty lines.

bye,
Sumit

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2018

I also have only one small nitpick, there seem to be a dot before util, can you squash this patch?

diff --git a/src/tests/intg/test_pam_responder.py b/src/tests/intg/test_pam_responder.py
index b0892857a..09aedd7b7 100644
--- a/src/tests/intg/test_pam_responder.py
+++ b/src/tests/intg/test_pam_responder.py
@@ -30,7 +30,7 @@ import pytest

 import config

-from .util import unindent
+from util import unindent


 def format_pam_cert_auth_conf():

sumit-bose added some commits Jun 20, 2018

PAM: create pre-auth indicator file
If pam_cert_auth is enabled the PAM responder will automatically create
the pre-authentication indicator file to tell pam_sss to do the pre-auth
step to find out about the available authentication methods.

Related to https://pagure.io/SSSD/sssd/issue/3500

@sumit-bose sumit-bose force-pushed the sumit-bose:preauth_for_certauth branch from 7db8e95 to d2b183f Jun 29, 2018

@sumit-bose

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2018

The latest version fixes the typo.

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2018

retest this please

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2018

I'm sorry I forgot to add the accepted label after the trivial change was done. Feel free to ping me if I forget again next time.

@jhrozek jhrozek added the Pushed label Jul 9, 2018

@jhrozek jhrozek closed this Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.