sdap: respect passwordGracelimit #621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrozek
reviewed
Jul 20, 2018
| /* ... and that's the reason why we have to set | ||
| * on_grace_login_limit to true here! ... | ||
| */ | ||
| on_grace_login_limit = pp_grace >= 0; |
There was a problem hiding this comment.
There is already a block which evaluates pp_grace >= 0 below, do you think it makes sense to move setting on_grace_login_limit=true there? Or did you want the variable to be set to false as well explicitly?
There was a problem hiding this comment.
If we add the check on the if, for cases where pp_grace < 0 we won't set on_grace_login_limit to false.
I thought about it, but then we'd have to, most likely, add an else there and it would make the code less clear.
There was a problem hiding this comment.
alternatively, set the variable to false where the pp_grace >= 0 is now and only to true in the block where pp_grace is already tested for >=0
Since recent changes in 389-ds two response controls are end when passwordGracelimit is set and about to expire: - [1.3.6.1.4.1.42.2.27.8.5.1] for the GraceLimit itself - [2.16.840.1.113730.3.4.4] for the PasswordExpired Whenever the former is returned and the GraceLimit is still valid, we shouldn't report the latter to the users. Resolves: https://pagure.io/SSSD/sssd/issue/3597 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
jhrozek
approved these changes
Jul 20, 2018
|
before adding the accepted label I will run some downstream tests |
|
This was referenced May 2, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since recent changes in 389-ds two response controls are end when
passwordGracelimit is set and about to expire:
Whenever the former is returned and the GraceLimit is still valid, we
shouldn't report the latter to the users.
Resolves:
https://pagure.io/SSSD/sssd/issue/3597
Signed-off-by: Fabiano Fidêncio fidencio@redhat.com