Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sss_ssh_knownhostsproxy: fix typo pubkey -> pubkeys #635

Closed
wants to merge 1 commit into from

Conversation

fidencio
Copy link
Contributor

In commit 36f2fe8 a discrepancy between the command line option and
the manpage has been introduced.

Related:
https://pagure.io/SSSD/sssd/issue/3542

Signed-off-by: Fabiano Fidêncio fidencio@redhat.com

@fidencio
Copy link
Contributor Author

re-test this, please

In commit 36f2fe8 a discrepancy between the command line option and
the manpage has been introduced.

Related:
https://pagure.io/SSSD/sssd/issue/3542

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
@jhrozek
Copy link
Contributor

jhrozek commented Aug 13, 2018

LGTM, let's give CI time to finish

@fidencio
Copy link
Contributor Author

After a quick chat with @jhrozek, I've decided to re-submit the patch and treated the manual reference (pubkeys) as a typo as we should not break command line compatibility by changing the command line option.

@fidencio
Copy link
Contributor Author

master:
2b3b41d

@fidencio fidencio closed this Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants