Analyzer: Ensure parsed id contains digit #6448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In analyzer list verbose output, we parse the last field of cache_req_search_send() lines. Certain log messages need to be filtered out by ensuring the parsed field is a digit, such as the last line below. [cache_req_search_send] (0x0400): [CID#1] CR #1: Looking up GID:1031401119@testrealm.test [cache_req_search_send] (0x0400): [CID#1] CR #1: Looking up GID:1031401119@testrealm.test [cache_req_search_send] (0x0400): [CID#1] CR #1: Looking up GID:1031401119@domain-zflo.com [cache_req_search_send] (0x0400): [CID#1] CR #1: Returning [GID:1031401119@domain-zflo.com] from cache Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Tomáš Halman <thalman@redhat.com> (cherry picked from commit bfa8d50)
ikerexxe
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Just a little comment. The commit message contains information about who reviewed it for master. I don't know if that will cause some type of issue when merging it in sssd-2-7 branch.
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>
(cherry picked from commit https://github.com/SSSD/sssd/commit/bfa8d50c479cf8ef7b299eb5848309a3a9ea7f12)
Apart from that LGTM.
It shouldn't. This is our typical way to backport patches (cherry-pick -x). |
alexey-tikhonov
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In analyzer list verbose output, we parse the last field of cache_req_search_send() lines. Certain log messages need to be filtered out by ensuring the parsed field is a digit, such as the last line below.
[cache_req_search_send] (0x0400): [CID#1] CR #1: Looking up GID:1031401119@testrealm.test [cache_req_search_send] (0x0400): [CID#1] CR #1: Looking up GID:1031401119@testrealm.test [cache_req_search_send] (0x0400): [CID#1] CR #1: Looking up GID:1031401119@domain-zflo.com [cache_req_search_send] (0x0400): [CID#1] CR #1: Returning [GID:1031401119@domain-zflo.com] from cache
Reviewed-by: Iker Pedrosa ipedrosa@redhat.com
Reviewed-by: Tomáš Halman thalman@redhat.com
(cherry picked from commit bfa8d50)