PAC: allow to disable UPN check and relax default check - sssd-2-7 #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently on IPA clients a calculated principal based on the user name and the Kerberos realm is added to the cached user object. This code is quite old and might have been necessary at times when sub-domain support was added to SSSD. But since quite some time SSSD is capable of generating the principal on the fly during authentication if nothing is stored in the cache. Removing the code makes the cache more consistent with other use-cases, e.g. with the IPA server where this attribute is empty, and allows to properly detect a missing UPN, e.g. during the PAC validation. Resolves: SSSD#6451 (cherry picked from commit b3d7a4f)
To avoid issues with the UPN check during PAC validation when 'ldap_user_principal' is set to a not existing attribute to skip reading user principals a new 'pac_check' option, 'check_upn_allow_missing' is added to the default options. With this option only a log message is shown but the check will not fail. Resolves: SSSD#6451 (cherry picked from commit 51b11db)
alexey-tikhonov
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid issues with the UPN check during PAC validation when
'ldap_user_principal' is set to a not existing attribute to skip reading
user principals a new 'pac_check' option, 'check_upn_allow_missing' is
added to the default options. With this option only a log message is shown
but the check will not fail.
Resolves: #6451